Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of cleanup #432

Merged
merged 13 commits into from
Sep 18, 2023
Merged

A bit of cleanup #432

merged 13 commits into from
Sep 18, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Sep 17, 2023

Description

This PR does some random cleaning of docstrings, links, imports and other minor stuff. ✨✨

Changes

  • Removes unused imports
  • Uses https links
  • Adds some missing strings
  • Brings back pandoc_binary for non apple OSs. Ubuntu 22 comes with pandoc 2.9 which is not enough for mkdocs_bibtex to work

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito requested a review from schroedk September 17, 2023 15:14
@mdbenito mdbenito marked this pull request as ready for review September 17, 2023 15:14
@mdbenito
Copy link
Collaborator Author

@schroedk tagging you bc of the change back to pandoc_binary

@mdbenito mdbenito self-assigned this Sep 17, 2023
@mdbenito mdbenito added the cleanup when code is ugly or unreadable and needs restyling label Sep 17, 2023
@mdbenito mdbenito merged commit 8a38884 into develop Sep 18, 2023
12 checks passed
@mdbenito mdbenito deleted the fix/cleanup branch September 18, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants