Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish.yaml #422

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

AnesBenmerzoug
Copy link
Collaborator

Description

This PR adds missing env variables to the publish CI job
that prevented pushing new docs.

Hopefully with this fix we can trigger the deployment of a new PyPI package using the develop branch's CI file.

Changes

  • Defined GITHUB_BOT* env variable in publish workfloa.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@AnesBenmerzoug AnesBenmerzoug self-assigned this Sep 4, 2023
@mdbenito
Copy link
Collaborator

mdbenito commented Sep 7, 2023

Sorry, I’m lost here. Why is that env var necessary and what problem are we trying to solve?

@AnesBenmerzoug
Copy link
Collaborator Author

Those 2 env vars represent the Github Bot user. They are used when pushing a new version of the docs to the gh-pages branch and since they were missing it was always failing. I didn't notice it before because they were just passed as empty strings (default for undefined env vars).

@mdbenito mdbenito merged commit 51cccff into develop Sep 7, 2023
2 checks passed
@mdbenito mdbenito deleted the fix/publish-workflow-missing-env-variables branch September 7, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants