Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize and decouple Scorer #301

Closed
2 tasks
mdbenito opened this issue Mar 6, 2023 · 1 comment
Closed
2 tasks

Parametrize and decouple Scorer #301

mdbenito opened this issue Mar 6, 2023 · 1 comment
Assignees
@mdbenito
Labels
breaking-change Changes to the API cleanup when code is ugly or unreadable and needs restyling enhancement New feature or request
Milestone
v0.10.0

Comments

@mdbenito
Copy link
Collaborator

mdbenito commented Mar 6, 2023 •
edited
Loading

  • Make Scorer accept tensors and return tensors (e.g. to allow returning the model parameters)
  • Constructing from strings should be a factory
@mdbenito mdbenito added enhancement New feature or request cleanup when code is ugly or unreadable and needs restyling labels Mar 6, 2023
@mdbenito mdbenito added this to the Ready for public release milestone Mar 8, 2023
@mdbenito mdbenito added the breaking-change Changes to the API label Mar 8, 2023
@mdbenito mdbenito self-assigned this Mar 9, 2023
@mdbenito mdbenito modified the milestones: v0.7.0, v0.9.0 Apr 20, 2023
@schroedk
Copy link
Collaborator

schroedk commented Sep 9, 2024

This issue is outdated, due to the new code structure via #558.

@schroedk schroedk closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdbenito mdbenito

Labels
breaking-change Changes to the API cleanup when code is ugly or unreadable and needs restyling enhancement New feature or request
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@mdbenito @schroedk