Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods like description_string_index() should return Option<NonZeroU8> #88

Open
raphaelcohn opened this issue Jul 27, 2021 · 0 comments · May be fixed by #89
Open

Methods like description_string_index() should return Option<NonZeroU8> #88

raphaelcohn opened this issue Jul 27, 2021 · 0 comments · May be fixed by #89

Comments

@raphaelcohn
Copy link

Methods like description_string_index() should return Option<NonZeroU8>, as Some(0) is impossible.
a1ien added a commit that referenced this issue Jul 27, 2021
@a1ien
Replace some Option<u8> to Option<NonZeroU8>
6b15215 
manufacturer_string_index
serial_number_string_index
product_string_index
description_string_index

ref #88
@a1ien a1ien linked a pull request Jul 27, 2021 that will close this issue
Open
a1ien added a commit that referenced this issue Jul 27, 2021
@a1ien
Replace some Option<u8> to Option<NonZeroU8>
be02e4f 
manufacturer_string_index
serial_number_string_index
product_string_index
description_string_index

ref #88
a1ien added a commit that referenced this issue Jul 27, 2021
@a1ien
Replace some Option<u8> to Option<NonZeroU8>
7c952ba 
manufacturer_string_index
serial_number_string_index
product_string_index
description_string_index

ref #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace some Option<u8> to Option<NonZeroU8> a1ien/rusb
1 participant
@raphaelcohn