Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open geo intents #806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Open geo intents #806

wants to merge 1 commit into from

Conversation

ann-who
Copy link
Contributor

@ann-who ann-who commented Oct 30, 2024

Solution #387

While implementing the changes, I encountered two problems that might be worth to discuss:

  • I had to use a GlobalKey for navigation. This was necessary because without it when the app was opened on another page (for example, 'Profile'), the geo intent was processed but the page remained the same. GlobalKey solves this problem but if there are more logic with deeplinks, I would suggest to consider named routing.

  • When the coordinates are opened, the zoom level in the app stays as it was set by the user previously. It might be worth considering this and finding an optimal zoom level.

Please take a look :)

mnalis added a commit to mnalis/every_door that referenced this pull request Oct 30, 2024
@Zverik
Copy link
Owner

Zverik commented Nov 15, 2024

@mnalis I see you tried to test this, did it go well? :)

Ann, thanks for the pull request! I'll look into it soon!

@mnalis
Copy link
Contributor

mnalis commented Nov 16, 2024

@mnalis I see you tried to test this, did it go well? :)

Ah, Thanks for the reminder... I did hit another problem with building APK in the process (#810) so had to put it aside... But I've managed to build it now (with extra changes for modified appid, hopefully it's not the cause of breaking it) in https://github.com/mnalis/every_door/actions/runs/11865626297 and I'm having partial success on Android 14:

  • when sharing the geo: link, the EveryDoor app appears in the list, and that is always good!
  • however, while sometimes it will work fine, sometimes (especially if EveryDoor was not in memory / recent apps?) the opening of geo: will not focus on new location, but instead open at old location (which was open via previous run). What is interesting, if one exists EveryDoor and enters it again, it will position it correctly.
  • sometimes it will locate, but it would be too zoomed out, not in the originally shared zoom level (that issue is mentioned in original PR comment)

Here is video of one not-working correctly (sharing from OsmAnd to EveryDoor):

small_Screen_Recording_20241116_015943_Every.Door.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants