-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question #2
Comments
Hi there Ronald, I originally created this library to have a simple library that can read and write Wave files. The wave format is very simple so a "header only" library is really all you need if you don't need support for any other formats. Currently pretty much all my repos are "on hold" (i.e. I'm not working on them), because I have a lot of work and personal stuff to deal with that takes priority. But if you would like to contribute, feel very free to do so (: Thanks in advance ^^ Cheers, |
Hi, Thanks for your quick reply - I've seen projects where it would take months to get one :) I'll let you know when I have something. The speakerlayout may or may not be a part of it, I'll make that it's own file or at least, class. In the mean time, good luck with your work and other stuff, it's very relatable! Cheers, |
Okay, another question: do you prefer pull requests, or issues with a description of the issue, and a description of the fix with sample code? I have a number of items I'd like to have your opinion on as well:
The chunks I would like to read: I'm currently downloading some Looperman samples, and seeing a lot of weird stuff going on in those WAV files (https://www.looperman.com/loops/detail/241433/groovy-synth-bass-loop-michael-jackson-style-free-120bpm-dance-bass-synth-loop manages to have: bext, JUNK, Fake, fmt and data chunks - in that order!!).
Anyway, just let me know how you'd like to see change requests: as issue or as PR. I'm fine with either but it seems less work for you to look at pull requests. |
Hey there (: I would prefer pull requests, but feel free to create issue threads if you come across something you don't manage to implement yourself.
I know. The thing is kinda held together with toothpicks and glue. Since I only used it for working Wave files, I didn't put much thought to error checking. I agree, that should definitely be done.
I think at the time I was working on this library I found it quite difficult to find reliable sources of information for the WAVE-Format. It seemed like all the websites I visited portrayed conflicting messages. Especially about the different WAVE format types and padding bytes. That's also why I didn't dare touching anything beyond the most basic metadata chunks. But sure, the more the better, right?
Seems like a good idea to me. Giving things a more object oriented structure would be a good idea in general. Right now it's kind of all over the place with lots of "magic values". Back then I didn't know better 😅
Sure, especially for testing purposes this will be interesting. I just used what I had on hand to test it and downloaded a few more samples from the internet. Though of course I didn't publish those here.
Yupp, sounds like a plan (: Thank you for your burning desire to contribute ^^ Cheers |
Cool, I'll start on preparing for it then :) |
Hi Zuzu-Typ,
Can I ask what your plans are with this mod? There is also a WavFile reader and writer in SciPy (https://docs.scipy.org/doc/scipy/reference/generated/scipy.io.wavfile.read.html) that does part of this. They have a rather large community but change requests can take years. They're also focused on just reading/writing and less on metadata support.
I'd like to add some stuff, notably ChannelMask and speaker layouts, 24-bit support, and normalization support (the latter taken from SciPy.wavfile). My main interest is that I can: read all current formats I have on my harddisk (96Khz/24 bit, 32 bit floating point, 8-32 bit fixed), read and copy all metadata if required for a 100% accurate copy, and display normalized data on a (real time) plot.
If you don't want that, it's cool. But if you agree, I'll add a few pull requests here and there over the coming weeks.
Cheers,
Ronald.
The text was updated successfully, but these errors were encountered: