You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if "fps" in kwargs:
warnings.warn(
"The keyword `fps` is no longer supported. Use `duration`"
"(in ms) instead, e.g. `fps=50` == `duration=20` (1000 * 1/50).",
DeprecationWarning,
)
kwargs["duration"] = 1000 * 1 / kwargs.get("fps")
Problem
The fps of the generated gif file of function
write_gif_with_image_io
is not correct.Minimal Case
The following code is similar to the function
write_gif_with_image_io
, but the generated gif's fps is not equal to the fps in the code.moviepy/moviepy/video/io/gif_writers.py
Line 422 in bc8d1a8
Potential Reason
As the following imageio code, the
duration
is inms
. But thewrite_gif_with_image_io
maybe think it issecond
.https://github.com/imageio/imageio/blob/ac863934d590ffc64155475a0fc365c1c82a8267/imageio/plugins/pillow.py#L408-L413
moviepy/moviepy/video/io/gif_writers.py
Lines 441 to 443 in bc8d1a8
The text was updated successfully, but these errors were encountered: