Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin: Convert key hash to Bitcoin address #53

Open
jornfranke opened this issue Mar 18, 2018 · 2 comments
Open

Bitcoin: Convert key hash to Bitcoin address #53

jornfranke opened this issue Mar 18, 2018 · 2 comments

Comments

@jornfranke
Copy link
Member

At the moment BitcoinScriptPatternParser returns the key hash which can be used to identify the unique address of a transaction and also to search it in blockchain explorers.
Bitcoin has also the notation of Bitcoin addresses which are primarily for users to improve the user experience. The conversion of such addresses is described in https://github.com/bitcoin/bips/blob/master/bip-0013.mediawiki

The idea of this issue is to create a functionality BitcoinScriptPatternParser.getBitcoinAddress(String) that converts the output of BitcoinScriptPatternParser.getPaymentDestination to a bitcoin address (if possible). Additionally we create HiveUDFs. All new methods need to be unit tested and documentation needs to be updated.

@phelps-sg
Copy link
Contributor

Is there any progress on this issue? If not, then I will be happy to start implementing this.

@jornfranke
Copy link
Member Author

Ah sorry yes you can implement it, i did not do much there, because there was no urgent need for my analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants