Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace autoload.lua with Play Next File In Dir on Media End #28

Open
Pentaphon opened this issue Dec 9, 2022 · 2 comments
Open

Replace autoload.lua with Play Next File In Dir on Media End #28

Pentaphon opened this issue Dec 9, 2022 · 2 comments

Comments

@Pentaphon
Copy link

Can we have this function built in to tethys? It seems natural to include a feature like skipping to the next file in the folder like https://github.com/tomasklaen/uosc does but some people may not want that osc and prefer yours.

@Zren
Copy link
Owner

Zren commented Dec 9, 2022

I don't quite understand the need to bundle the official autoload.lua script inside tethys.lua. Is there a change that is necessary or something? Or GUI toggle? Or is this just to make the install easier?

Does uosc do the autoload differently?

https://github.com/tomasklaen/uosc/blob/17c8ed62912acd1fc23371a29e7a84f5c6b54175/scripts/uosc.lua#L467

Seems like instead of loading the entire folder as a playlist at load time, it dynamically goes to the next file when the media ends. This way it'll play the next video even if the next few videos is still downloading.

@Zren Zren changed the title Remove need for autoload.lua with built-in solution? Replace autoload.lua with Play Next File In Dir on Media End Dec 9, 2022
@Pentaphon
Copy link
Author

Pentaphon commented Dec 10, 2022

It just makes the whole install easier and more cohesive by having it built-in to the Tethys UI, you know? Tethys seems to emulate the classic media player design like Bomi, mpc-hc, smplayer, etc which all have the abilty to play the next video in a folder if the user turns on that playback option so it should just include the ability to play the next video in a folder without relying on another script that wasn't meant for Tethys.

And yes, dynamically going to the next file, as well as letting users press a button to go to the next file early (to skip end credits) is essentially what I want. uosc also lists all the files in that folder in a menu on the player Ui so you can open any one of them as well but that might be asking for too much. It's a handy feature to have, especially considering how many TV episodes people watch these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants