Add pallets #8
Merged
Add pallets #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
0xPxt
approved these changes
Nov 7, 2024
abenso
force-pushed
the
feat/add_pallets
branch
from
77b7544 to
ca79fa1
Compare
neithanmo
approved these changes
Nov 8, 2024
| uint64_t _len; | ||
| const uint8_t* _ptr; | ||
| uint64_t _lenBuffer; | ||
| } pd_VecTupleDataData_t; |
There was a problem hiding this comment.
Not critical, but why the repeated DataData?
There was a problem hiding this comment.
This represents the type BoundedVec<(Data, Data)>, so the name is correct
abenso
force-pushed
the
feat/add_pallets
branch
from
88bd43a to
1d471ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Vector
Proxy
Identity
Mandate
TechnicalCommittee
Grandpa
Scheduler