Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform #96

Open
4 tasks
Zhiyuan-Amos opened this issue Oct 31, 2021 · 6 comments
Open
4 tasks

Terraform #96

Zhiyuan-Amos opened this issue Oct 31, 2021 · 6 comments

Comments

@Zhiyuan-Amos
Copy link
Owner

Zhiyuan-Amos commented Oct 31, 2021

Also consider:

  1. What happens when Creating, Updating & Deleting resources both outside & inside of existing Resource Groups managed by Terraform, are made through the UI?
  2. Can the UI be disabled for modifications? If so, should we do it?
  3. How to create a Test Environment to test new configurations?
  4. Azure Static Web App doesn't gel well with Test Environments, because Azure Static Web App by default creates up to 3 staging environments. We can ignore these though.
  • TF upgrade to OIDC
  • Documentation for why states are managed in a seperate resource group
  • Concurrency Management for workflows Supporting docs
  • How to cater for multiple branches, to seperate by multiple publish profile in the key vault --> to create a seperate issue
@Zhiyuan-Amos
Copy link
Owner Author

Zhiyuan-Amos commented Dec 14, 2021

[Enhancement] Rollback is required to support the scenario:

  1. Push SWA updates
  2. Push Azure Fn updates
  3. Push Infrastructure updates

Such that when any of these steps fail, it should rollback to the previous version.

@Zhiyuan-Amos
Copy link
Owner Author

Zhiyuan-Amos commented Dec 22, 2021

[Enhancement] How do we spin up a new environment & run tests after new commits are merged into master?

@Zhiyuan-Amos
Copy link
Owner Author

Zhiyuan-Amos commented Dec 22, 2021

[Enhancement] Do we spin up a new env on PR created?

@Zhiyuan-Amos
Copy link
Owner Author

Likely have 3 environments: Dev, Test, Prod. Test environment will be dynamically created after new commits are merged into master.

@Zhiyuan-Amos
Copy link
Owner Author

Does monolithic deployment consisting of several steps a good practice? As each service is being updated individually, this can lead to bugs occurring if the caller service is updated but the callee service hasn't been updated. Should it be rectified on the code level where the code provides backward compatibility?

@gohyk
Copy link
Collaborator

gohyk commented May 11, 2022

Currently, we're performing Azure Login with OpenID Connect(OIDC) and use it in a GitHub Actions. However, Terraform have yet to support OIDC in their Terraform configurations here: https://github{dot}com/hashicorp/terraform-provider-azurerm/issues/16554

Repository owner deleted a comment from Zhiyuan-Amos May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants