From 0353934948d52689fa65a91acfa86267e0be84f5 Mon Sep 17 00:00:00 2001 From: Joseph Perez Date: Thu, 25 Apr 2024 16:45:03 +0200 Subject: [PATCH] refactor: remove `KeyExpr::with_parameters` See https://github.com/eclipse-zenoh/zenoh/pull/979 --- src/key_expr.rs | 5 ----- zenoh/__init__.pyi | 2 -- 2 files changed, 7 deletions(-) diff --git a/src/key_expr.rs b/src/key_expr.rs index 9f455dfd..8c9251a6 100644 --- a/src/key_expr.rs +++ b/src/key_expr.rs @@ -67,11 +67,6 @@ impl KeyExpr { self.0.concat(&other).into_pyres().map_into() } - // TODO https://github.com/eclipse-zenoh/zenoh/pull/974 - fn with_parameters(&self, parameters: String) -> Selector { - self.0.clone().with_owned_parameters(parameters).into() - } - // Cannot use `#[pyo3(from_py_with = "...")]`, see https://github.com/PyO3/pyo3/issues/4113 fn __eq__(&self, other: &Bound) -> PyResult { Ok(self.0 == Self::from_py(other)?.0) diff --git a/zenoh/__init__.pyi b/zenoh/__init__.pyi index b7b2e7a6..61f131c3 100644 --- a/zenoh/__init__.pyi +++ b/zenoh/__init__.pyi @@ -371,8 +371,6 @@ class KeyExpr: You should probably prefer KeyExpr::join as Zenoh may then take advantage of the hierachical separation it ins erts. """ - def with_parameters(self, parameters: str) -> Selector: ... - _IntoKeyExpr = KeyExpr | str @final