Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue in the SFC shortcut function #17

Open
chenhanpolyu opened this issue Dec 22, 2022 · 1 comment
Open

Minor issue in the SFC shortcut function #17

chenhanpolyu opened this issue Dec 22, 2022 · 1 comment

Comments

@chenhanpolyu
Copy link

Recently I read your code about generating the shortcut SFC, and I found this line is kind of confusing. Maybe it should be "i= j;"?, or could you explain the reason why it should be "i = j+1"?
In my understanding, when you find two polyhedrons that connect to each other, you should keep the newly connected polyhedron as the short SFC's tail and find another polyhedron to connect to it (but not choose the former polyhedron as the SFC tail).

@ChanJoon
Copy link

@chenhanpolyu Did you find your own answer? I also wonder why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants