Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Intersection method in rasterize based on geometry type (#20) 🎁 #21

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

whisperingpixel
Copy link
Contributor

@whisperingpixel whisperingpixel commented Mar 2, 2023

Description

This selects the intersection method in the rasterize function based on geometry types. Polygons and MultiPolygons use intersection of pixel centroids, (Multi)Lines and (Multi)Points use touch. Note: If at least one (Multi)LinesPolygon is in there, centroid intersection is used. See the following issue for more details.

Relates to #20

Type of change

Select one or more relevant options:

  • Bug fix (change which fixes a bug reported in a specific issue)
  • New feature (change which adds a feature requested in a specific issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improved documentation for existing functionality in the package)
  • Repository update (change related to non-package files or structures in the GitHub repository)

Checklist:

  • I have read and understood the contributor guidelines of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I ran all demo notebooks locally and there where no errors

@whisperingpixel whisperingpixel marked this pull request as ready for review March 2, 2023 18:11
@luukvdmeer luukvdmeer merged commit 0429e4c into main Mar 8, 2023
@luukvdmeer luukvdmeer deleted the different-rasterize-methods-20 branch March 8, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants