Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Attractive footer #206

Closed
wants to merge 7 commits into from
Closed

Design Attractive footer #206

wants to merge 7 commits into from

Conversation

Neutx
Copy link

@Neutx Neutx commented Jan 5, 2023 •
edited
Loading

Purpose

The purpose of this Pull Request is to fix #194

Goals

Add an attractive footer

Screenshots

https://cdn.discordapp.com/attachments/802898705002266644/1060562215834497034/image.png

Preview Link

https://pr-206-new-yoshitha-website.surge.sh/

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title of this PR @Neutx

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
assets/css/styles.css Outdated Show resolved Hide resolved
assets/css/styles.css Outdated Show resolved Hide resolved
assets/css/styles.css Outdated Show resolved Hide resolved
assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/index.html Outdated Show resolved Hide resolved
dark/index.html Outdated Show resolved Hide resolved
dark/index.html Outdated Show resolved Hide resolved
dark/index.html Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/index.html Outdated Show resolved Hide resolved
dark/index.html Outdated Show resolved Hide resolved
dark/index.html Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/index.html Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/index.html Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
dark/index.html Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have deleted some necessary files, don't remove them keep them as it was @Neutx

YoshithaRathnayake
YoshithaRathnayake reviewed Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neutx Sorry, I can't accept this PR because there are lot of changes you have done and some of them have changed the main content also, so the footer is very nice if you can undo that changes I can approve this

@Neutx Neutx changed the title my commit Design Attractive footer PR Jan 6, 2023
@Neutx
Copy link
Author

Neutx commented Jan 6, 2023

Can you change the title of this PR @Neutx

@Neutx Neutx closed this Jan 6, 2023
@Neutx Neutx reopened this Jan 6, 2023
@Neutx
Copy link
Author

Neutx commented Jan 6, 2023

All the requested changes have been performed.

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
@YoshithaRathnayake YoshithaRathnayake changed the title Design Attractive footer PR Design Attractive footer Jan 6, 2023
YoshithaRathnayake
YoshithaRathnayake reviewed Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me @Neutx

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the preview link to this? @Neutx
https://pr-206-NEW-YOSHITHA-WEBSITE.surge.sh

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the issue number to #194 @Neutx

@Neutx
Copy link
Author

Neutx commented Jan 6, 2023

Change the issue number to #194 @Neutx

@Neutx Neutx closed this Jan 6, 2023
@Neutx Neutx reopened this Jan 6, 2023
YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the issue number to this
The purpose of this Pull Request is to fix #194

image

YoshithaRathnayake
YoshithaRathnayake reviewed Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more changes that change the main content of the website @Neutx

YoshithaRathnayake
YoshithaRathnayake requested changes Jan 6, 2023
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

@Neutx Neutx closed this by deleting the head repository Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshithaRathnayake YoshithaRathnayake YoshithaRathnayake requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design a attractive footer
2 participants
@Neutx @YoshithaRathnayake