Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request the scripts to add custom cell type labels to the Cell Ontology #52

Open
Starlitnightly opened this issue Nov 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Starlitnightly
Copy link

Description of feature

Hi,

I noticed the following description in the main text, could you provide the scripts to add custom cell type labels to the Cell Ontology?

Sincerely,
Zehua

"We recommend that in any newly added reference datasets, the annotations should be consistent with Cell Ontology, either by matching terms in the ontology or by hierarchically assigning new terms to existing terms in the ontology. To this end, we provide scripts to add custom cell type labels to the Cell Ontology before processing by popV (where it is used for running OnClass and calculating our consensus scores)."

@Starlitnightly Starlitnightly added the enhancement New feature or request label Nov 25, 2024
@shobhitagrawal1
Copy link

Thanks to the authors for this repo!
@Starlitnightly the reproducibility repository has some scripts (https://github.com/YosefLab/popv-reproducibility/tree/main/ontology_creation) but I couldn't really figure it out how to do it on my data. Any help would be appreciated, an example notebook would be great.

@canergen
Copy link
Member

canergen commented Dec 1, 2024

Hi, thanks for your interest. I hope to get to create a notebook end of this week that walks through adding celltypes and retraining the nlp embedding for OnClass. Currently, as shown in the tutorial, you can set the ontology to false to disable OnClass. If you feel that the OBO ontology is missing important terms, they actively take suggestions in to extend it.

@canergen
Copy link
Member

I have pushed a version of it in: https://github.com/YosefLab/popV/blob/cuml_enabled2/add_celltypes_ontology.ipynb. This branch is functional. However, I am retraining the pretrained models for Tabula sapiens still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants