From 6565d5ef7e1621698a82fd374053251c2f3b5668 Mon Sep 17 00:00:00 2001
From: Igor <35524806+igorschoester@users.noreply.github.com>
Date: Thu, 12 Sep 2024 15:29:16 +0200
Subject: [PATCH] Fix SelectControl deprecation warning

Gutenberg added a deprecation warning for SelectControl via https://github.com/WordPress/gutenberg/issues/38730
This opts in to that behavior and adds the margin top to the ExternalLink below (therefor needing block layout to get the margin to take effect)
---
 packages/js/src/components/PrimaryTaxonomyPicker.js | 2 +-
 packages/js/src/components/TaxonomyPicker.js        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/js/src/components/PrimaryTaxonomyPicker.js b/packages/js/src/components/PrimaryTaxonomyPicker.js
index cbf46617f95..ab5be3801d4 100644
--- a/packages/js/src/components/PrimaryTaxonomyPicker.js
+++ b/packages/js/src/components/PrimaryTaxonomyPicker.js
@@ -244,7 +244,7 @@ class PrimaryTaxonomyPicker extends Component {
 					id={ fieldId }
 					terms={ this.state.selectedTerms }
 				/>
-				<ExternalLink href={ learnMoreLink }>
+				<ExternalLink className="yst-inline-block yst-mt-2" href={ learnMoreLink }>
 					{ __( "Learn more", "wordpress-seo" ) }
 					<span className="screen-reader-text">
 						{ __( "Learn more about the primary category.", "wordpress-seo" ) }
diff --git a/packages/js/src/components/TaxonomyPicker.js b/packages/js/src/components/TaxonomyPicker.js
index 2dd803fd966..1b0f4f8afdd 100644
--- a/packages/js/src/components/TaxonomyPicker.js
+++ b/packages/js/src/components/TaxonomyPicker.js
@@ -21,6 +21,7 @@ const TaxonomyPicker = ( { id, value, terms, label, onChange } ) => {
 
 	return (
 		<SelectControl
+			__nextHasNoMarginBottom={ true }
 			__next40pxDefaultSize={ true }
 			id={ id }
 			label={ label }