Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Warn users of Classic blocks to convert to Gutenberg blocks #429

Open
JessieHenkes opened this issue Dec 23, 2019 · 3 comments
Open

Warn users of Classic blocks to convert to Gutenberg blocks #429

JessieHenkes opened this issue Dec 23, 2019 · 3 comments

Comments

@JessieHenkes
Copy link

JessieHenkes commented Dec 23, 2019

Explanation

Users of Classic Blocks in Gutenberg do not see any assessment results, because we can't identify and analyse these blocks. Therefor we want to warn users of those blocks that we do not support those blocks and that if they want to see some assessment results, they need to convert this specific block to a Gutenberg block.

Technical decisions

  • We need to create and push a warning to users, to make them convert to Gutenberg if they face problems with Classic blocks
  • We do NOT adjust the researchers in order to make them analysing those classic blocks
  • We will not include the texts of these blocks in the analysis: they will be fully ignored

Feedback?

@nataliashitova @manuelaugustin @hansjovis: does this description and proposed solution cover the discussion we had? Please feel free to add!

@hansjovis
Copy link
Contributor

I cannot seem to reproduce the issue that Classic Blocks do not get analyzed.
Do we have a bug report that I can use for context?

@nataliashitova
Copy link
Contributor

Design issue: https://github.com/Yoast/design/issues/609

@nataliashitova
Copy link
Contributor

The current situation is that Classic blocks do get analyzed for Yoast checks, but not consistently with the normal Gutenberg text blocks.
If we throw a warning about no support for Classic blocks and need to convert to Gutenberg blocks while still taking the content of the Classic blocks into account to some extent that will be confusing.
In my opinion, this issue should also include a task "Refrain completely from analyzing Classic blocks in the Gutenberg editor".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants