Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

[Next major release] Rename the classes #51

Open
jrfnl opened this issue Oct 28, 2019 · 0 comments
Open

[Next major release] Rename the classes #51

jrfnl opened this issue Oct 28, 2019 · 0 comments

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Oct 28, 2019

Related to #29 and #49. This change should be made in the next major release of this module.

The class names currently don't comply with the Camel_Caps class name rule.

From a PHP-perspective this is a safe change as class-names are treated case-insensitively, however, as there is a bug in the Composer which makes the class map autoloader case-sensitive, this change needs to be made in a major release.

For each plugin which uses this module, the class instantiation new Classname() calls will need to be updated when the dependency is updated.

The change which needs to be made is the change as previously made in #29.

Note: if/when this module would start to use namespacing, that would also be a good time to address this issue simultaneously.

@jrfnl jrfnl changed the title [Next majore release] Rename the classes [Next major release] Rename the classes Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant