Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Added extra checks within the metatag generators in case fields do not exist, fixed hasSitemapFields method with correct property #553

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Aug 31, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Metatag generators could throw errors trying to access fields which were not available
  • hasSitemapFields incorrectly returned yoastSeoFields instead of sitemapFields

Relevant technical choices:

  • Added ?? checks to the possibly non-existing fields

Test instructions

This PR can be tested by following these steps:

  • Pull branch
  • Test if setSitemapFields(false) really does not add the fields in the backend
  • Test if the frontend does not throw errors when fields in the database (like og_image) do no exist

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #550

…lds do not exist, fixed hasSitemapFields method with correct property
@RinyVT RinyVT merged commit 4dc99b9 into main Sep 12, 2023
@RinyVT RinyVT deleted the bugfix/550-automatic-functionality-records branch October 31, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic functionality for records not working
1 participant