Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install: [Mac IDE] Installing should not put the old version's .app in the trash with a "copy" label appended #8467

Closed
1 of 2 tasks
yerumaku opened this issue Nov 20, 2024 · 6 comments
Assignees
Labels
ide-bug Bugs with the GameMaker IDE
Milestone

Comments

@yerumaku
Copy link

Description

There is a problem when installing the Beta version, with each installation a file is placed in the trash and is not cleared from it.

Image

Expected Change

No response

Steps To Reproduce

  1. Download GameMaker
  2. Install GameMaker
  3. Reinstall GameMaker
  4. See the issue

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1100 (Betas)

Which operating system(s) are you seeing the problem on?

macOS Sequoia

Are you running GameMaker from inside your Steam library?

No

Sample Package Attached?

  • I have attached my bug package

Sample Project Added?

  • I have included a small sample project
@yerumaku yerumaku added the ide-bug Bugs with the GameMaker IDE label Nov 20, 2024
@rwkay
Copy link

rwkay commented Nov 20, 2024

The mac way is to clean out your trash every so often... you do empty your trash don't you??

If mac requires disk space it will prompt you to empty the trash yourself - in extreme circumstances it may well scavenge space from the trash can

@rwkay
Copy link

rwkay commented Nov 20, 2024

I have checked the code and we are moving the previous app into the trash in our installer... so it is us doing it - I am not sure what we should do here though - we explicitly rename for the all the copies... so we could just make it one level deep - but then we are emptying the trash ourselves... users may want to keep the previous ones

@yerumaku
Copy link
Author

It is not entirely clear to me why the entire application should be moved to the trash if it is replaced by another one in the process of reinstalling (updating the version). Thus, garbage accumulates just like that, and then how to distinguish if the file is renamed?

Let's say the user wants to return the previous version, but has to do it from the trash or install the version from the installer?

Speaking specifically about me, I prefer to empty the trash manually, but as a user of the engine, I have a question to store the installers of stable versions in some directory or already installed versions in the trash named "copy"x10 and try to distinguish them?

I think then it is necessary to warn the user that when reinstalling (placing files in the trash) that the program file will be moved to the trash.

@yerumaku
Copy link
Author

Image

As a user, it is beneficial for me to store the installer, rather than copy-copy in the trash:

  1. The installer takes up less space.
  2. On macOS, there is no quick "restore file" option from the trash like on Windows OS. That is, I will need to manually drag and drop the file and rename it back.

@stuckie stuckie moved this from Triage to Backlog in Team Workload Nov 21, 2024
@YYDan YYDan changed the title IDE: Mac Installing the basket is clogged Install: [Mac IDE] Installing puts the old version's .app in the trash with a "copy" label appended, should use the version number instead Nov 21, 2024
@rwkay
Copy link

rwkay commented Nov 25, 2024

Fixed in 2024.11 - I have removed the copy of the old app to the trashcan completely - not sure exactly why we did that.

@rwkay rwkay closed this as completed Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload Nov 25, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Nov 26, 2024
@YYDan YYDan added this to the 2024.11 milestone Nov 28, 2024
@YYDan YYDan changed the title Install: [Mac IDE] Installing puts the old version's .app in the trash with a "copy" label appended, should use the version number instead Install: [Mac IDE] Installing should not puts the old version's .app in the trash with a "copy" label appended Nov 28, 2024
@YYDan YYDan changed the title Install: [Mac IDE] Installing should not puts the old version's .app in the trash with a "copy" label appended Install: [Mac IDE] Installing should not put the old version's .app in the trash with a "copy" label appended Nov 28, 2024
@mgeddesGM
Copy link

verified as of IDE v2024.1100.0.701 Runtime v2024.1100.0.719

@mgeddesGM mgeddesGM moved this from Ready for QA to Verified in Team Workload Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE
Projects
Status: Verified
Development

No branches or pull requests

4 participants