Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Editor 2/LSP: [Ubu IDE] "Language Server for GML" crashes and notifies frequently in 2024.1100 Beta 6 #8399

Closed
gnysek opened this issue Nov 13, 2024 — with GM Bug Reporter · 5 comments
Assignees
Labels
ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached
Milestone

Comments

@gnysek
Copy link
Contributor

gnysek commented Nov 13, 2024

Description

On Ubuntu, I'm getting some notifiactions about Language Server for GML has been restarted and after some time info, that it crashed 3 times, so will be no no longer restarting.

Steps To Reproduce

  1. Open any project
  2. Write some code, or just click in few places (including folding/unfolding)
  3. Check for blue baloon in top-right corner

Which version of GameMaker are you reporting this issue for?

IDE v2024.1100.0.674 Runtime v2024.1100.0.700

Which operating system(s) are you seeing the problem on?

Linux Ubuntu 22.04.5 LTS kernel 6.8.0.48

Attached Files

  • Zrzut ekranu z 2024-11-13 20-10-17.png
  • ui.log

74f687e3-96d0-4f78-8b95-ffb91bde601d

@gm-bug-reporter gm-bug-reporter bot added ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached labels Nov 13, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Nov 14, 2024
@stuckie stuckie moved this from Backlog to Todo in Team Workload Nov 14, 2024
@stuckie stuckie added this to the 2024.11 milestone Nov 14, 2024
@stuckie
Copy link

stuckie commented Nov 14, 2024

This might already be fixed in the next Beta release, following changes since the last public Beta. We will review if that is the case, or whether this is a bigger fix and so needs to wait for after 2024.11.

@YYDan YYDan changed the title [Ubuntu] LS for GML crashes Code Editor 2/LSP: [Ubu IDE] "Language Server for GML" crashes and notifies frequently in 2024.1100 Beta 6 Nov 14, 2024
@stuckie
Copy link

stuckie commented Nov 18, 2024

We are thinking this is now fixed as of the 2024.1100.0.686 release, if you could confirm that on your setup, thanks!

@gnysek
Copy link
Contributor Author

gnysek commented Nov 19, 2024

It still happens on .686:

Image

However, I have some suspicion that it crashes only on Start Page now (and those messages just comes with little delay), as I didn't have more than two and they shown very early after opening project.

@stuckie stuckie modified the milestones: 2024.11, 2025.1 Nov 21, 2024
@zreedy zreedy moved this from Todo to In Progress in Team Workload Nov 22, 2024
@zreedy
Copy link

zreedy commented Nov 22, 2024

Fixed. This issue was related to errant PDEATHSIG signals raised for the forking thread. The Client spawns the Server via a TPL Task which does not have a guaranteed lifetime of the Client's process. The Server subscribed to the PDEATHSIG to be terminated when raised.
Since this signal is raised for thread termination not process termination we cannot rely on it to terminate an orphaned Server process. Instead we now poll the current PPID once a second and gracefully terminate if the PPID migrates.

@YYDan YYDan modified the milestones: 2025.1, 2024.11 Nov 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 29, 2024
@YYDan YYDan moved this from Done to Ready for QA in Team Workload Dec 2, 2024
@Emc1923
Copy link

Emc1923 commented Dec 12, 2024

Verified as of IDE v2024.1100.0.713 Runtime v2024.1100.0.726

@Emc1923 Emc1923 moved this from Ready for QA to Verified in Team Workload Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached
Projects
Status: Verified
Development

No branches or pull requests

6 participants