Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stats API #26

Open
Yiling-J opened this issue Jun 18, 2023 · 3 comments
Open

Add Stats API #26

Yiling-J opened this issue Jun 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Yiling-J
Copy link
Owner

Yiling-J commented Jun 18, 2023

  • Add RecordStats option to builder
  • Add entry_count/get_count/miss_count/evict_count stats(total/ram/nvm), atomic uint64 should be enough
  • Add nvm read/sync time percentile stats and loading cache load stats, using sliding window(fixed size, 60 seconds, 60 digests) & t-digest
  • Add Stats API
@Yiling-J Yiling-J added the enhancement New feature or request label Jun 18, 2023
@Yiling-J Yiling-J self-assigned this Jun 18, 2023
@aryehlev
Copy link

@Yiling-J love this repo I've been wanting to do this for a while,
I can take this issue on me if u want

@Yiling-J
Copy link
Owner Author

Hi @aryehlev 1,2,4 in my comment are not difficult to implement, but the third one is a little tricky. I've done some work on the branch: https://github.com/Yiling-J/theine-go/tree/feature/stats, but the code is a bit messy. I'm busy recently so contributions are welcome! If you're interested in taking this issue, you can take a look at my branch for some ideas.

@Yiling-J
Copy link
Owner Author

Hi @aryehlev, are you working on this? I will have some time next month, if you haven't started yet I will try to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants