Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JL, JLE, JG, JGE, ... dont work properly #21

Open
88aleksandr88 opened this issue Aug 24, 2023 · 2 comments · May be fixed by #25
Open

JL, JLE, JG, JGE, ... dont work properly #21

88aleksandr88 opened this issue Aug 24, 2023 · 2 comments · May be fixed by #25
Labels
bug Something isn't working

Comments

@88aleksandr88
Copy link

`start:
;JG, JGE Bug:
MOV AX, 20
MOV BX, -10
CMP AX, BX
JG AX_GREATER_THAN_BX ;JG, JGE is for signed numbers
MOV AX, 0 ;But no jump made
AX_GREATER_THAN_BX: ;Must jump here
MOV AX, 0

;JL, JLE Bug
MOV AX, 20
MOV BX, -10
CMP AX, BX
JL AX_LESSER_THAN_BX ;JL, JLE is for signed numbers
MOV AX, 0 ;Must no jump
AX_LESSER_THAN_BX: ;Jumps here
MOV AX, 0`

@88aleksandr88
Copy link
Author

Feature-proposal:
Can the last outputted line in emulator (characters) be black instead of grey?

@YJDoc2
Copy link
Owner

YJDoc2 commented Oct 4, 2023

Hey, apologies for the delay, I got busy with something and missed this.

Can the last outputted line in emulator (characters) be black instead of grey?

It can be done, however, that will need to be in the web repo, and also need to check from accessibility perspective, which I'm not that much familiar with.

The example you mentioned indeed seems like a bug, I think I have an idea of what might have gone wrong. I'll try to fix it as soon as I can.

Thanks for reporting!

@YJDoc2 YJDoc2 added the bug Something isn't working label Oct 4, 2023
@vzabrodin vzabrodin linked a pull request Feb 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants