Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace confirm dialog with a Bootstrap modal #145

Open
kburk1997 opened this issue Dec 2, 2017 · 1 comment
Open

Replace confirm dialog with a Bootstrap modal #145

kburk1997 opened this issue Dec 2, 2017 · 1 comment
Labels
angular design frontend
Milestone
Spring 2018 - Mis...

Comments

@kburk1997
Copy link
Member

Right now, the user is asked to confirm unsaved changes or the deletion of an object with a standard JavaScript dialog. This is very annoying to test because even when using spies, the tester has to manually click the confirm to get the tests to pass. A Bootstrap modal would be much easier to test because it wouldn't show up in the test console. Also, JavaScript dialogs are disgusting
@kburk1997 kburk1997 mentioned this issue Feb 13, 2018
Closed
@kburk1997
Copy link
Member Author

Alternatively, we can only display the confirm dialog on prod and staging environments, but this may reduce our test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
angular design frontend
Projects
None yet
Milestone
Spring 2018 - Misc Frontend Enhancements
Development

No branches or pull requests
1 participant
@kburk1997