Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own instance not selectable #202

Open
Tealk opened this issue Nov 28, 2023 · 13 comments
Open

Own instance not selectable #202

Tealk opened this issue Nov 28, 2023 · 13 comments
Labels
bug Something isn't working

Comments

@Tealk
Copy link

Tealk commented Nov 28, 2023

Describe the bug
A clear and concise description of what the bug is.

To Reproduce (if applicable)
Steps to reproduce the behavior:

  1. open Lemmy photon
  2. open the ModLog
  3. enter the domain of your own instance in the search field

Expected behavior
only the logs of your own instance are displayed when you search for them

Screenshots
image

Versions

  • Browser: Firefox 120.0
  • Photon version:v1.23.2
    • check in the bottom of the main menu.
@Tealk Tealk added the bug Something isn't working label Nov 28, 2023
@0xCmdrKeen
Copy link
Contributor

This is sort of by design because your home instance is the default anyways when no instance is selected.

But I suppose it would help avoid confusion if it did in fact show up when you search for it. Let me see what I can do about this.

@Tealk
Copy link
Author

Tealk commented Nov 28, 2023

have i misunderstood the search? i thought i could use it to filter for moderations per instance?
So when I search rollenspiel.forum I only see the moderations of my instance.

@0xCmdrKeen
Copy link
Contributor

Ah, I see. The value of the instance box defines which server the modlog is fetched from. In the original issue (#195), I noted that it appears that some modlog entries propagate to other servers, while others do not.

The point of adding this box was basically to allow users to check other servers for their version of the modlog without having to leave Photon.

Honestly, this whole thing was really just a quick proof-of-concept I hacked together, didn't expect it to get merged so fast.

@0xCmdrKeen
Copy link
Contributor

So anyways, I guess opens up an interesting conundrum, because your expectation certainly isn't wrong, and it's difficult to explain to the end user what the difference is between a mod action being taken on a specific server and that action appearing on a given server's modlog.

TBH, I'm pretty new to Lemmy myself and I don't know exactly how this happens myself, if anyone can point me to the relevant docs, that would be great. All I've been able to ascertain by experimentation is what I said earlier — there isn't a single, globally unique version of the modlog but instead, every instance has its own version. And sometimes that includes actions taken on other servers, and other times it doesn't.

@Tealk
Copy link
Author

Tealk commented Nov 28, 2023

In the end, you can see all moderative actions in the log that are known to the server.

@0xCmdrKeen
Copy link
Contributor

In the end, you can see all moderative actions in the log that are known to the server.

Correct.

@Xyphyn
Copy link
Owner

Xyphyn commented Nov 28, 2023

Perhaps we should remove the instance search as you can just change your guest instance URL if you want to see a different modlog

@0xCmdrKeen
Copy link
Contributor

Well, I certainly didn't intend for my first draft at this to get merged so quickly, so I wouldn't be upset if you do remove it.

However, I think there's been some good feedback here and I think there could be an improvement made over using the guest instance, because that takes several extra clicks to change.

@0xCmdrKeen
Copy link
Contributor

I do have to admit that on second thought, I certainly helped contribute to @Tealk's confusion because the instance autoselectbox is clearly labeled "filter by instance". So I really can't blame him for his expectation here.

@0xCmdrKeen
Copy link
Contributor

Okay, just thinking out loud here, but how about this: when you go to /instances, you see a list of linked and blocked instances.

image

What if, hypothetically, those were all clickable, and when you click on one (and it's a lemmy server), it pulls up that server's sidebar, along with the links to their modlog. And instead of having a "filter by instance" autoselect on it, it looks like it did beforehand, and instead the instance name is passed via a path component (i.e. /modlog/[instance])?

That should be far less confusing and almost as simple, right?

@0xCmdrKeen
Copy link
Contributor

0xCmdrKeen commented Nov 29, 2023

I guess the question would be what happens when you click on a non-Lemmy server. It looks like the Mastodon API does have a similar endpoint to Lemmy's /v3/site call (/v1/instance), which provides much of the same info (user count, post count, thumbnail, "about" blurb). So as long as a server responds to one or the other, the sidebar could still be populated, and if it isn't Lemmy, we just wouldn't show the modlog button.

@Tealk
Copy link
Author

Tealk commented Nov 29, 2023

I do have to admit that on second thought, I certainly helped contribute to @Tealk's confusion because the instance autoselectbox is clearly labeled "filter by instance". So I really can't blame him for his expectation here.

Is it not possible to design the filter so that it filters according to the moderator?
So [email protected] is then found under the filter rollenspiel.forum.
And all other moderators with the same ending?
Wouldn't be entirely correct, because you can also have moderators from other instances, but a start?

@0xCmdrKeen
Copy link
Contributor

@Tealk I believe that's already implemented, but according to what I'm seeing in the code, that option only shows up if you are an admin on your current instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants