Prevent assignments of FX modules to model #1143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
When replacing a module by a RotatedModule in fused_rotation_no_fx via a ModuleInstanceToModuleInstance rewriter, a tying between the model and its FX counterpart is created, as the replaced module in the model will point to a RotatedModule which, itself, points to module of the FX model. This is an inconsistency which is problematic when registering parametrizations, for instance.
Changes Made in this PR
Create a new type of rewriter for wrapping a module with a new class, which, itself, contains an instance to the original module. This rewriter is less general than ModuleInstanceToModuleInstance, but it is more transparent for this specific use-case.
Testing Summary
To be added.
Risk Highlight
Checklist
dev
branch.