Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Enhancing the SaveManager, and sharing data between scenes. #38

Open
benmoran56 opened this issue Apr 27, 2018 · 7 comments
Open

Comments

@benmoran56
Copy link
Collaborator

We will need to enhance the saving/loading features, and also easily share data betwen the different Scenes. I have a plan to do this, but I would like your feedback.

  1. The SceneManager will gain a few dictionaries. This will include an "options" dictionary, containing things such as "fullscreen", "volume levels", etc. This will also include an "inventory" dictionary.
  2. The SceneManager class will have a reference to the SaveManager. This means that all Scenes can access it (because all Scenes already have a reference to self.scene_manager).

In this design, the MenuScene can check the self.scene_manager['options']['fullscreen'] value to see if the game should be full screen. An OptionsScene could be used to set all of these things. When you are playing, you bring up the inventory Scene, and make some actions. The GameScene can see this data when you return to the game.

If it helps, I will make a pull request with the basic design. You can decide if you like it or not. As always, feel free to reject any pull requests you do not like.

@XenonLab-Studio
Copy link
Owner

@benmoran56 It's actually what I had in mind for a long time. I like it, because it's a good way to keep the savemode and game options separate from the engine. I really like your way of thinking, and keeping the project organized like you are doing is an excellent idea that I really appreciate.

@benmoran56
Copy link
Collaborator Author

That's great. I'm glad that we have similar ideas, and I've been enjoying working on this.

@XenonLab-Studio
Copy link
Owner

@benmoran56 Thank you, I promise to include your name in the wiki, and throughout the project. Having fun is the important goal, getting better, and sharing your knowledge.

Thank you so much, it's nice to meet people who think like you :)

@benmoran56
Copy link
Collaborator Author

I've been working on this a bit. I have a pull request, but I'm testing some other changes too.

@XenonLab-Studio
Copy link
Owner

Good. Thank you very much. As soon as I have time, I commit my graphic resources.

@benmoran56
Copy link
Collaborator Author

Regarding graphics, what do you think about separate .pngs for each block type? Would this be easier to add new block types later?

@XenonLab-Studio
Copy link
Owner

Yes, absolutely! it's much simpler and I recommend using the 16x16 pixel standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants