From 73e4c917d575d49dcb2a2251f6f10405f0f96a31 Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Fri, 7 Jun 2024 23:18:28 -0400 Subject: [PATCH 01/10] Update PhpUnit versions --- .github/workflows/pr_tests.yml | 38 ++++++++++++++++++++++++++-------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml index 89131dc..33fbae8 100644 --- a/.github/workflows/pr_tests.yml +++ b/.github/workflows/pr_tests.yml @@ -3,11 +3,11 @@ name: CI on: [push, pull_request] jobs: - phpunit-7-1: + phpunit-9-6: strategy: fail-fast: false matrix: - php_version: ["7.1", "7.4"] + php_version: ["7.4", "8.1", "8.2", "8.3"] runs-on: ubuntu-latest steps: @@ -20,25 +20,45 @@ jobs: with: php-version: ${{ matrix.php_version }} coverage: xdebug - - name: Unit Tests with PHPUnit 7.1 - run: vendor/bin/phpunit --stderr --version 7.1 + - name: Unit Tests with PHPUnit 9.6 + run: vendor/bin/phpunit --stderr --version 9.6 + + phpunit-10-5: + strategy: + fail-fast: false + matrix: + php_version: ["8.1", "8.2", "8.3"] + runs-on: ubuntu-latest - phpunit-9-6: + steps: + - uses: actions/checkout@v2 + - uses: php-actions/composer@v6 + with: + php_version: "8.1" + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php_version }} + coverage: xdebug + - name: Unit Tests with PHPUnit 10.5 + run: vendor/bin/phpunit --stderr --version 10.5 + + phpunit-11-2: strategy: fail-fast: false matrix: - php_version: ["8.1"] + php_version: ["8.2", "8.3"] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - uses: php-actions/composer@v6 with: - php_version: "7.4" + php_version: "8.2" - name: Setup PHP uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php_version }} coverage: xdebug - - name: Unit Tests with PHPUnit 9.6 - run: vendor/bin/phpunit --stderr --version 9.6 + - name: Unit Tests with PHPUnit 11.2 + run: vendor/bin/phpunit --stderr --version 11.2 From 297f24a3d1a3af74dc225e9a68fb1fcf650cc622 Mon Sep 17 00:00:00 2001 From: mambax7 Date: Fri, 20 Sep 2024 03:27:18 -0400 Subject: [PATCH 02/10] sync --- .github/workflows/pr_tests.yml | 38 ++++++-- composer.json | 16 ++-- docs/changelog.md | 162 +++++++++++++++++++++++++++++++++ 3 files changed, 199 insertions(+), 17 deletions(-) diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml index 89131dc..33fbae8 100644 --- a/.github/workflows/pr_tests.yml +++ b/.github/workflows/pr_tests.yml @@ -3,11 +3,11 @@ name: CI on: [push, pull_request] jobs: - phpunit-7-1: + phpunit-9-6: strategy: fail-fast: false matrix: - php_version: ["7.1", "7.4"] + php_version: ["7.4", "8.1", "8.2", "8.3"] runs-on: ubuntu-latest steps: @@ -20,25 +20,45 @@ jobs: with: php-version: ${{ matrix.php_version }} coverage: xdebug - - name: Unit Tests with PHPUnit 7.1 - run: vendor/bin/phpunit --stderr --version 7.1 + - name: Unit Tests with PHPUnit 9.6 + run: vendor/bin/phpunit --stderr --version 9.6 + + phpunit-10-5: + strategy: + fail-fast: false + matrix: + php_version: ["8.1", "8.2", "8.3"] + runs-on: ubuntu-latest - phpunit-9-6: + steps: + - uses: actions/checkout@v2 + - uses: php-actions/composer@v6 + with: + php_version: "8.1" + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php_version }} + coverage: xdebug + - name: Unit Tests with PHPUnit 10.5 + run: vendor/bin/phpunit --stderr --version 10.5 + + phpunit-11-2: strategy: fail-fast: false matrix: - php_version: ["8.1"] + php_version: ["8.2", "8.3"] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - uses: php-actions/composer@v6 with: - php_version: "7.4" + php_version: "8.2" - name: Setup PHP uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php_version }} coverage: xdebug - - name: Unit Tests with PHPUnit 9.6 - run: vendor/bin/phpunit --stderr --version 9.6 + - name: Unit Tests with PHPUnit 11.2 + run: vendor/bin/phpunit --stderr --version 11.2 diff --git a/composer.json b/composer.json index 0a0d875..a0ae181 100644 --- a/composer.json +++ b/composer.json @@ -9,16 +9,16 @@ } }, "require": { - "php": ">=5.6.0", - "kint-php/kint": "^3.3", - "symfony/yaml": "^2.8", - "paragonie/random_compat": "^2", - "firebase/php-jwt": "6.0.0", - "webmozart/assert": "1.9.1" + "php": ">=7.4.0", + "kint-php/kint": "^5.1.1", + "symfony/yaml": "^5.4.39", + "paragonie/random_compat": "^9.99.100", + "firebase/php-jwt": "^6.10.0", + "webmozart/assert": "^1.11.0" }, "require-dev": { - "phpunit/phpunit": "^7.0", - "roave/security-advisories": "dev-master" + "phpunit/phpunit": "^9.6", + "roave/security-advisories": "dev-latest" }, "autoload-dev": { "psr-4": { diff --git a/docs/changelog.md b/docs/changelog.md index 919edaa..8d8544f 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -1,6 +1,168 @@ xmf ChangeLog ============= +May 30, 2024 v1.2.30 +------------------ +* upgrade Smarty to 4.5.3 + + +Nov 20, 2023 v1.2.29 +------------------ +* add Random::generateSecureRandomBytes() +* replace random_bytes() with generateSecureRandomBytes() for PHP 5.6 + + +Oct 30, 2023 v1.2.28 +------------------ +* Updates to library dependencies +* PHP 8.0 Error Suppression operator issues +* Handle case of no permissionHandler found +* Adds ULID support +* cosmetic and code improvements + +Mar 19, 2023 v1.2.27 +------------------ +* Update to firebase/php-jwt 6.0.0 + +Apr 16, 2022 v1.2.26 +------------------ +* Add Xmf\Module\Helper\Permission::getItemIds($gperm_name, $gperm_groupid) +* Use new module version in XoopsCore25 +* Fix issues in Xmf\Database\Tables and Xmf\Database\Migrate +* Fix some issues related to new PHP versions + +May 7, 2021 v1.2.25 +------------------ +* add \Xmf\Module\Admin::renderNavigation() method + +Mar 25, 2021 v1.2.24 +------------------ +* Fixes for PHP 5.3 compatibility + +Feb 15, 2021 v1.2.23 +------------------ +* Additional fix in Debug for Kint 3.3 + +Feb 13, 2021 v1.2.22 +------------------ +* fixes in Debug for Kint 3.3 + +Feb 13, 2021 v1.2.21 +------------------ +* Library updates +* XOOPS standardization +* Minor code cleanups + +Aug 18, 2020 v1.2.20 +------------------ +* \Xmf\Module\Helper\AbstractHelper::serializeForHelperLog() fix logging of a resource type +* Unit test updates for latest version of Webmozart\Assert + +Feb 13, 2020 v1.2.19 +------------------ +* \Xmf\Yaml::read() eliminate PHP warning if specified file does not exist. + +Dec 1, 2019 v1.2.18 +------------------ +* PHP 7.4 ready +* fix error in Database\Table::loadTableFromYamlFile() +* add Uuid::packAsBinary() and Uuid::unpackBinary() methods +* add Module/Helper/GenericHelper::uploadPath() and uploadUrl() methods +* add proxy support in IPAddress::fromRequest(); + +Mar 27, 2019 v1.2.17 +------------------ +- Docblock corrections + +Nov 29, 2018 v1.2.16 +------------------ +- Fix database column quoting + +Oct 1, 2018 v1.2.15 +------------------ +- Fix database column quoting for prefix indexes +- Add dirname() method to helper classes +- Changes Request::hasVar() default for $hash to 'default' + +Mar 30, 2018 v1.2.14 +------------------ +- add serialization to non-scalar log data +- improved handling of custom key storage +- add some unit testing +- add roave/security-advisories requirement to catch security issues at build time +- Synchronization with XoopsCore + +Nov 12, 2017 v1.2.12 +------------------ +- updates the supporting Kint library to version 2.2. + +Nov 12, 2017 v1.2.11 +------------------ +- adds support for UUID generation using the Xmf\Uuid class. + +Jul 24, 2017 v1.2.10 +------------------ +- fixes issues in Xmf\Random appearing under PHP 7.1. Xmf\Random will now avoid the mcrypt extension if at all possible, and use the native random_bytes() function in PHP 7+. + +May 19, 2017 v1.2.9 +------------------ +- fixes issues in Xmf\Highlighter and Xmf\Metagen + +May 7, 2017 v1.2.8 +------------------ +- add a missing option in \Xmf\Module\Helper\Permission::checkPermission() + +Apr 29, 2017 v1.2.7 +------------------ +- fixes issue with Xmf\Metagen::generateSeoTitle + +Apr 18, 2017 v1.2.6 +------------------ +- fixes issues with Xmf\Request::MASK_ALLOW_HTML + +Apr 3, 2017 v1.2.5 +------------------ +- updates to kint-php/kint + +Mar 6, 2017 v1.2.4 +------------------ +- adds Xmf\Assert + +Mar 3, 2017 v1.2.3 +------------------ +- synchronizes some minor docblock changes + +Feb 25, 2017 v1.2.2 +------------------ +- corrects issues with Yaml:readWrapped() + +Nov 2, 2016 v1.2.0 +------------------ +- Separates the stop word logic from MetaGen into a new StopWords class +- Deprecates MetaGen::checkStopWords() + +Sep 11, 2016 v1.1.4 +------------------ +- #17 Handle non-ascii text in Metagen::generateKeywords() + +Aug 13, 2016 v1.1.3 +------------------ +- Fix #15 XoopsRequest class not found in StripSlashesRecursive method + +Aug 6, 2016 v1.1.2 +------------------ +- Fix #13 Can't check isUserAdmin on Anonymous + +Jul 28, 2016 v1.1.1 +------------------ +- firebase/php-jwt to 4.0.0 +- Bump min PHP to 5.3.9 to allow symfony/yaml 2.8.* + +Jul 14, 2016 v1.1.0 +------------------ +- Add Xmf\Database\Migrate class to provide schema synchronization capabilities for modules. +- Bug fixes in Xmf\Database\Tables including option to disable automatic quoting of values in update() and insert() to support using column functions instead of only scalars + 01-Jun-2016 V1.0.2 ------------------ - fix issues with file name validation in Xmf\Language::loadFile() From 2dd4171368ecd482557f568dd2fbd489d213b7b1 Mon Sep 17 00:00:00 2001 From: mambax7 Date: Fri, 20 Sep 2024 03:34:34 -0400 Subject: [PATCH 03/10] updated Debug for Kint changes --- docs/changelog.md | 4 ++++ src/Debug.php | 13 ++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/docs/changelog.md b/docs/changelog.md index 8d8544f..4574beb 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -1,6 +1,10 @@ xmf ChangeLog ============= +Sep 19, 2024 v1.2.31 +------------------ +* updated Debug for Kint changes + May 30, 2024 v1.2.30 ------------------ * upgrade Smarty to 4.5.3 diff --git a/src/Debug.php b/src/Debug.php index 450e552..66a38c7 100644 --- a/src/Debug.php +++ b/src/Debug.php @@ -11,6 +11,7 @@ namespace Xmf; +use Kint\Kint; /** * Debugging tools for developers * @@ -22,7 +23,7 @@ * @license GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html) * @link https://xoops.org */ -class Debug extends \Kint +class Debug extends Kint { /** * doOnce - do some local housekeeping on first use. Any method needing this @@ -39,7 +40,7 @@ private static function doOnce() parent::$aliases[] = array($class, 'dump'); parent::$aliases[] = array($class, 'backtrace'); parent::$enabled_mode = true; - parent::$mode_default = \Kint::MODE_RICH; + parent::$mode_default = Kint::MODE_RICH; // display output inline ::folder = false, true puts all output at bottom of window \Kint\Renderer\RichRenderer::$folder = false; // options: 'original' (default), 'solarized', 'solarized-dark' and 'aante-light' @@ -50,16 +51,14 @@ private static function doOnce() /** * Dump one or more variables * - * @param mixed $data variable(s) to dump - * + * @psalm-param array ...$args * @return void */ - public static function dump($data = null) + public static function dump(...$args) { - $args = func_get_args(); static::doOnce(); - forward_static_call_array(array('parent', 'dump'), $args); + parent::dump(...$args); } /** From 455bda381e043acdfab4badc6fc94cd5a59617a3 Mon Sep 17 00:00:00 2001 From: mambax7 Date: Mon, 11 Nov 2024 01:00:48 -0500 Subject: [PATCH 04/10] PHP 8.4 Implicitly nullable parameter --- src/Jwt/KeyFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Jwt/KeyFactory.php b/src/Jwt/KeyFactory.php index de6387c..a90e429 100644 --- a/src/Jwt/KeyFactory.php +++ b/src/Jwt/KeyFactory.php @@ -38,7 +38,7 @@ class KeyFactory * * @throws \InvalidArgumentException on unusable key name */ - public static function build($keyName, StorageInterface $storage = null) + public static function build($keyName, ?StorageInterface $storage = null) { if (empty($keyName) || !is_string($keyName)) { throw new \InvalidArgumentException('keyName must be a non-empty string'); From 848e61726bc1a34035ea8733865176142bf873f0 Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 22:04:41 -0500 Subject: [PATCH 05/10] composer updates --- composer.json | 6 +++--- docs/changelog.md | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/composer.json b/composer.json index a0ae181..05a1fb5 100644 --- a/composer.json +++ b/composer.json @@ -10,10 +10,10 @@ }, "require": { "php": ">=7.4.0", - "kint-php/kint": "^5.1.1", - "symfony/yaml": "^5.4.39", + "kint-php/kint": "^6.0", + "symfony/yaml": "^5.4.45", "paragonie/random_compat": "^9.99.100", - "firebase/php-jwt": "^6.10.0", + "firebase/php-jwt": "^6.10.2", "webmozart/assert": "^1.11.0" }, "require-dev": { diff --git a/docs/changelog.md b/docs/changelog.md index 4574beb..4ced6f9 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -3,7 +3,8 @@ xmf ChangeLog Sep 19, 2024 v1.2.31 ------------------ -* updated Debug for Kint changes +* updated Debug for Kint changes (mamba) +* added Issues Template (mamba) May 30, 2024 v1.2.30 ------------------ From f212e7cdbcf664d94c1f6ecc290af1a970808618 Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 22:05:04 -0500 Subject: [PATCH 06/10] Issues Template --- .github/CONTRIBUTING.md | 20 +++++++++++ .github/ISSUE_TEMPLATE/bug-report.yml | 40 ++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature-request.yml | 17 +++++++++ 3 files changed, 77 insertions(+) create mode 100644 .github/CONTRIBUTING.md create mode 100644 .github/ISSUE_TEMPLATE/bug-report.yml create mode 100644 .github/ISSUE_TEMPLATE/feature-request.yml diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md new file mode 100644 index 0000000..9a1bec9 --- /dev/null +++ b/.github/CONTRIBUTING.md @@ -0,0 +1,20 @@ +![alt XOOPS CMS](https://xoops.org/images/logoXoopsPhp81.png) +# Contributing to [XOOPS CMS](https://xoops.org) +[![XOOPS CMS Module](https://img.shields.io/badge/XOOPS%20CMS-Module-blue.svg)](https://xoops.org) +[![Software License](https://img.shields.io/badge/license-GPL-brightgreen.svg?style=flat)](https://www.gnu.org/licenses/gpl-2.0.html) + +Contributions are **welcome** and will be fully **credited**. + +We accept contributions via Pull Requests on [GitHub](https://github.com/XoopsModules25x/mymenus). + +## Pull Requests + +- **[PSR-12 Coding Standard](https://www.php-fig.org/psr/psr-12/)** - The easiest way to apply the conventions is to install [PHP Code Sniffer](http://pear.php.net/package/PHP_CodeSniffer). +- **Add tests!** - We encourage providing tests for your contributions. +- **Document any change in behavior** - Make sure the `/docs/changelog.txt` and any other relevant documentation are up-to-date. +- **Consider our release cycle** - We try to follow [Semantic Versioning v2.0.0](http://semver.org/). Randomly breaking public APIs is not an option. +- **Create feature branches** - Don't ask us to pull from your master branch. +- **One pull request per feature** - If you want to do more than one thing, send multiple pull requests. +- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting. + +Happy coding, and **_May the Source be with You_**! diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml new file mode 100644 index 0000000..407e19e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -0,0 +1,40 @@ +name: Bug Report +description: Report a bug or error, providing details about the issue, steps to reproduce, and your environment setup. +title: "[Bug]: " +labels: ['Triage', 'Bug'] +body: +- type: input + attributes: + label: Module Version + description: Provide the Module version that you are using. + value: 1.54-beta + validations: + required: true +- type: dropdown + attributes: + label: PHP Version + description: Provide the PHP version that you are using. + options: [ '7.4', '8.0','8.1','8.2','8.3', '8.4' ] + multiple: true + validations: + required: true +- type: dropdown + attributes: + label: Operating System + description: Provide the operating system that you are using. + options: ['Linux', 'MacOS', 'Windows', 'Other'] + multiple: true + validations: + required: true +- type: textarea + attributes: + label: Description + description: Please provide a detailed description of the issue you are running into. + validations: + required: true +- type: textarea + attributes: + label: Steps to Reproduce + description: Please provide detailed steps on how we can reproduce the issue you are reporting. For a shot at getting our "Perfect Storm" label, submit a PR with a failing test! + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml new file mode 100644 index 0000000..9d54c5c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -0,0 +1,17 @@ +name: Feature Request +description: This XOOPS Module is a work in progress! Let us know about a feature you would like to see in the module. +title: "[Feature Request]: " +labels: ['Triage', 'Feature Request'] +body: +- type: textarea + attributes: + label: Description + description: Please provide a detailed description of the feature you would like to see added. + validations: + required: true +- type: textarea + attributes: + label: Benefits + description: Please provide some thoughts on how this feature may benefit others using the module. + validations: + required: true From ffea5282eb5fe123cf561988877b14cecc9999ae Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 22:16:19 -0500 Subject: [PATCH 07/10] downgrade firebase/php-jwt to 6.10.0 for PHP 7.4 --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 05a1fb5..20fe2e9 100644 --- a/composer.json +++ b/composer.json @@ -13,7 +13,7 @@ "kint-php/kint": "^6.0", "symfony/yaml": "^5.4.45", "paragonie/random_compat": "^9.99.100", - "firebase/php-jwt": "^6.10.2", + "firebase/php-jwt": "^6.10.0", "webmozart/assert": "^1.11.0" }, "require-dev": { From 3a8e1525816cb2494dd5bc53e0e9afdf18dd65ed Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 22:23:12 -0500 Subject: [PATCH 08/10] Updates for PHP 8.4 --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- .travis.yml | 1 + docs/changelog.md | 5 ++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 407e19e..3b8418f 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -6,8 +6,8 @@ body: - type: input attributes: label: Module Version - description: Provide the Module version that you are using. - value: 1.54-beta + description: Provide the XOOPS version that you are using. + value: 2.5.12 validations: required: true - type: dropdown diff --git a/.travis.yml b/.travis.yml index 49f7b44..d758495 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ php: - 8.1 - 8.2 - 8.3 +- 8.4 matrix: allow_failures: diff --git a/docs/changelog.md b/docs/changelog.md index 4ced6f9..4f75dbc 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -1,10 +1,13 @@ xmf ChangeLog ============= -Sep 19, 2024 v1.2.31 +Nov 27, 2024 v1.2.31 ------------------ * updated Debug for Kint changes (mamba) * added Issues Template (mamba) +* PHP 8.4 Implicitly nullable parameters (mamba) +* Update PhpUnit versions (mamba) +* upgrade Smarty to 4.5.5 May 30, 2024 v1.2.30 ------------------ From 14c2b67e0f6b3d1a4d462dc7ddb63b9a7a5bbb83 Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 22:27:23 -0500 Subject: [PATCH 09/10] cosmetics --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- .github/ISSUE_TEMPLATE/feature-request.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 3b8418f..ba4c492 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -5,7 +5,7 @@ labels: ['Triage', 'Bug'] body: - type: input attributes: - label: Module Version + label: XOOPS Version description: Provide the XOOPS version that you are using. value: 2.5.12 validations: diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index 9d54c5c..0c6d3aa 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -1,5 +1,5 @@ name: Feature Request -description: This XOOPS Module is a work in progress! Let us know about a feature you would like to see in the module. +description: XMF (XOOPS Module Framework) is a work in progress! Let us know about a feature you would like to see in the module. title: "[Feature Request]: " labels: ['Triage', 'Feature Request'] body: From b2f17a27e74414ffad270501c39b8c12e84c6c73 Mon Sep 17 00:00:00 2001 From: Michael Beck Date: Wed, 27 Nov 2024 23:05:47 -0500 Subject: [PATCH 10/10] PHP 8.4 --- .github/workflows/pr_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml index 33fbae8..ebab65c 100644 --- a/.github/workflows/pr_tests.yml +++ b/.github/workflows/pr_tests.yml @@ -27,7 +27,7 @@ jobs: strategy: fail-fast: false matrix: - php_version: ["8.1", "8.2", "8.3"] + php_version: ["8.1", "8.2", "8.3" ] runs-on: ubuntu-latest steps: @@ -47,7 +47,7 @@ jobs: strategy: fail-fast: false matrix: - php_version: ["8.2", "8.3"] + php_version: ["8.2", "8.3", "8.4"] runs-on: ubuntu-latest steps: