Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XOOPS reads blocks from deactivated modules #1335

Open
mambax7 opened this issue Apr 14, 2023 · 8 comments
Open

XOOPS reads blocks from deactivated modules #1335

mambax7 opened this issue Apr 14, 2023 · 8 comments
Assignees
Labels

Comments

@mambax7
Copy link
Collaborator

mambax7 commented Apr 14, 2023

I was getting the same error as in #1329

I deactivated all modules, but the error was still there. From the error report, I saw that it complained about a block from a deactivated module. I had to go and deactivate the block, and then the error went away.

We should make sure that XOOPS doesn't read any blocks from deactivated modules. It's a waste of time as it reads blocks that are not going to be displayed, but also it will continue to report errors, incl. fatal errors, even if we deactivate a module because it was buggy

@mambax7 mambax7 added the bug label Apr 14, 2023
@alain01
Copy link
Contributor

alain01 commented Apr 14, 2023

Nice find!

@GregMage
Copy link
Contributor

Indeed, this behaviour is not good.
Can you give me more details so that I can look at the problem in detail?

@mambax7
Copy link
Collaborator Author

mambax7 commented Apr 14, 2023

I didn't have the time to investigate it in detail, because the module was outdated, so I just wanted to get XOOPS to work.
But based on what I've experienced, I assume that you could do following:

  1. Select an installed module that has active blocks, and deactivate it
  2. Go to one of the module's block code, or to the block's template and introduce a fatal error
  3. Go to the front page and see if it works

In my case, it was crashing, until I went to the module's block and deactivated

If you can't replicate it this way, let me know, and I'll try to investigate in more depth on my end

@GregMage
Copy link
Contributor

Okay, I'll take a look and let you know if I have a problem

@GregMage GregMage self-assigned this Apr 14, 2023
@GregMage
Copy link
Contributor

I added an error in the templates of a block of the xmnews module and the site does not work anymore. I deactivate the module and the site works. I can't reproduce the problem...

@mambax7
Copy link
Collaborator Author

mambax7 commented Apr 14, 2023

OK, I'll take a look here this weekend.

@GregMage
Copy link
Contributor

GregMage commented May 1, 2023

Do you have any other information? Because I couldn't reproduce your problem!

@mambax7
Copy link
Collaborator Author

mambax7 commented May 1, 2023

Still on my TODO list, and didn't have the time to get to it yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants