Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Target asset field should be empty when only sourceAsset is present in the deeplink #1136

Open
1 task done
tsadovska opened this issue Oct 17, 2024 · 0 comments
Open
1 task done

[bug] Target asset field should be empty when only sourceAsset is present in the deeplink #1136

tsadovska opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain

Comments

@tsadovska
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

ETH asset is selected as target asset.

Screenshot 2024-10-17 at 15 29 58

Expected Behavior

Target asset should not be selected, because only sourceAsset is present in the deeplink.

Steps To Reproduce

  1. Open https://preview.portalbridge.com/dd12faf4dd/?sourceChain=ethereum&targetChain=solana&sourceAsset=ETH
  2. Check if asset in "To" section is selected

Environment

- OS: macOS Sonoma 14.5
- Wallet: MetaMask, Phantom
- Browser: Google Chrome Version 129.0.6668.100 (Official Build) (arm64)

Anything else?

No response
@tsadovska tsadovska added bug Something isn't working medium Issue affecting one Tx / User / Chain labels Oct 17, 2024
sebastianscatularo added a commit that referenced this issue Oct 17, 2024
@sebastianscatularo
#1136 - remove the fallback value for targetAsset when it is not expl…
b92fd0c 
…icitly provided
sebastianscatularo added a commit that referenced this issue Oct 17, 2024
@sebastianscatularo
#1136 - remove the fallback value for targetAsset when it is not expl…
e3f071d 
…icitly provided
sebastianscatularo added a commit that referenced this issue Oct 17, 2024
@sebastianscatularo @artursapek @yuli-ferna
add preferred route and target asset param (#1134)
5337b64 
* add version & hash to mixpanel events

* changes

* New version of connect

* Test and type fixes

* REview fix

* Review fix

* Review fix

* Review fix

* Fix test

* Fix format

* add preferred route and target asset param

* fix prettier

* add unit test and fix old unit test

* fix prettier at test

* update docs

* update connect to use published beta

* #1136 - remove the fallback value for targetAsset when it is not explicitly provided

* fix unit test

* update docs, fix typos

* update connect version

* applied docs reviews

---------

Co-authored-by: Artur Sapek <[email protected]>
Co-authored-by: yuli-ferna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsadovska