From 1d19e55fba307b622828967ee9811bc0a9ba6798 Mon Sep 17 00:00:00 2001 From: Peter Williams Date: Fri, 15 Sep 2023 11:36:58 -0400 Subject: [PATCH 1/2] Require the latest engine in all dependent packages This way it can be nice and clear as to which package versions use the new pure-JS, ESM-based core engine. --- embed-creator/package.json | 2 +- embed/package.json | 2 +- engine-helpers/package.json | 2 +- engine-pinia/package.json | 2 +- engine-types/package.json | 2 +- research-app/package.json | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/embed-creator/package.json b/embed-creator/package.json index bcd44eba..a2a28f77 100644 --- a/embed-creator/package.json +++ b/embed-creator/package.json @@ -57,4 +57,4 @@ "serve": "vue-cli-service serve" }, "version": "0.0.0-dev.0" -} \ No newline at end of file +} diff --git a/embed/package.json b/embed/package.json index 9a60b2bd..11d7c4cb 100644 --- a/embed/package.json +++ b/embed/package.json @@ -40,7 +40,7 @@ "homepage": "https://worldwidetelescope.org/home/", "internalDepVersions": { "@wwtelescope/embed-common": "manual:workspace:>=0.2.0", - "@wwtelescope/engine": "1dded843ee47f132873d8b264bdba50badfea25f", + "@wwtelescope/engine": "thiscommit:2023-09-15:u5a68Lm", "@wwtelescope/engine-pinia": "thiscommit:2022-11-10:R3G9gH3" }, "keywords": [ diff --git a/engine-helpers/package.json b/engine-helpers/package.json index 5146a99d..375e440d 100644 --- a/engine-helpers/package.json +++ b/engine-helpers/package.json @@ -21,7 +21,7 @@ "homepage": "https://worldwidetelescope.org/home/", "internalDepVersions": { "@wwtelescope/astro": "manual:workspace:>=0.1.0", - "@wwtelescope/engine": "thiscommit:2023-06-08:wiuLDxn", + "@wwtelescope/engine": "thiscommit:2023-09-15:QN4FSax", "@wwtelescope/engine-types": "57d0450658d758832a11f628e890c061ad331ec2" }, "keywords": [ diff --git a/engine-pinia/package.json b/engine-pinia/package.json index 6dcea27c..bb0159f4 100644 --- a/engine-pinia/package.json +++ b/engine-pinia/package.json @@ -31,7 +31,7 @@ "homepage": "https://worldwidetelescope.org/home/", "internalDepVersions": { "@wwtelescope/astro": "thiscommit:2022-11-29:pfBFAzl", - "@wwtelescope/engine": "thiscommit:2023-06-08:jlRxuZ3", + "@wwtelescope/engine": "thiscommit:2023-09-15:tnfPTUa", "@wwtelescope/engine-helpers": "thiscommit:2023-06-08:51W7HwZ", "@wwtelescope/engine-types": "thiscommit:2022-11-29:OIQ6vzL" }, diff --git a/engine-types/package.json b/engine-types/package.json index 74b08965..076ac7a9 100644 --- a/engine-types/package.json +++ b/engine-types/package.json @@ -34,4 +34,4 @@ "type": "module", "types": "./dist/src/index.d.ts", "version": "0.0.0-dev.0" -} \ No newline at end of file +} diff --git a/research-app/package.json b/research-app/package.json index bdb8fd2a..7017f93e 100644 --- a/research-app/package.json +++ b/research-app/package.json @@ -47,7 +47,7 @@ "homepage": "https://worldwidetelescope.org/home/", "internalDepVersions": { "@wwtelescope/astro": "7cb232125428a91bd8fd10be24fec904e3589cce", - "@wwtelescope/engine": "thiscommit:2022-04-04:M9auxuE", + "@wwtelescope/engine": "thiscommit:2023-09-15:8Z0O5N5", "@wwtelescope/engine-helpers": "263bedcc26dd2d13d03ba68daece76aa5e16f145", "@wwtelescope/engine-pinia": "thiscommit:2022-11-10:R3G9gH3", "@wwtelescope/engine-types": "263bedcc26dd2d13d03ba68daece76aa5e16f145", From da66c8c097ca1091a57c1496ddd43f6868e82ab1 Mon Sep 17 00:00:00 2001 From: Peter Williams Date: Fri, 15 Sep 2023 11:43:52 -0400 Subject: [PATCH 2/2] README.md: add some notes about build challenges --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 909b977a..04fd21ed 100644 --- a/README.md +++ b/README.md @@ -43,6 +43,9 @@ workshops, and a variety of other needs. ## Developers’ quick start 1. Check out this repository to a machine with [Node.js] and [Yarn]. + 1. Builds with versions of Node.js around 18.17 may fail with [an Invalid URL + error](https://github.com/nodejs/node/issues/48855). + 1. There have also been reports of builds that hang on Linux with Node 20.x. 1. `git submodule update --init` 1. `yarn install` 1. `yarn lint` (uses [ESLint])