Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings (breaking changes) #264

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix clippy warnings (breaking changes) #264

wants to merge 5 commits into from

Conversation

mh-northlander
Copy link
Collaborator

partial fix for #40.

Fix clippy warnings (rest of #263).

Contains some breaking changes:

  • rm unused BAKED_DICTIONARY_BYTES
  • rm unused SplitIter
  • rename StringNumber.to_string -> get_normalized
  • change some func args more general (&String -> &str, &Vec -> &[])
  • RegexError.cause is boxed
  • AnalyzeNonSplitted and AnalyzeSplitted takes boxed SudachiOutput

This was referenced Jul 1, 2024
Merged
Closed
@mh-northlander mh-northlander force-pushed the fix/clippy-warnings-breaking branch from c1cd151 to daed1b7 Compare November 11, 2024 02:10
@mh-northlander mh-northlander linked an issue Nov 11, 2024 that may be closed by this pull request
Fix clippy warnings #40
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix clippy warnings
1 participant
@mh-northlander