Allow string literals as segmentation modes #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiennohito
force-pushed
the
feature/arseny/mode-literals
branch
from
27195ca to
65bab9d
Compare
| @@ -65,7 +70,7 @@ class Dictionary: | |||
| ... | |||
|
|
|||
| def create(self, | |||
| mode: SplitMode = SplitMode.C, | |||
| mode: Union[SplitMode, Literal["A"], Literal["B"], Literal["C"]] = SplitMode.C, | |||
There was a problem hiding this comment.
Let's use Union[SplitMode, Literal["A", "B", "C"]] as l.199.
python/src/dictionary.rs
Outdated
There was a problem hiding this comment.
Dictionary.pre_tokenizer also take split mode as an argument (l.292).
|
@mh-northlander fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
In addition to
SplitModeobjects SudachiPy will now accept A, B, C string literals as well (in all places).Split mode also gets a constructor that accepts string literal in addition to class members
Bonus fix: tokenization now releases GIL