Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-2623 Memory audit / make classes disposable #218

Open
evanweible-wf opened this issue Sep 9, 2016 · 3 comments
Open

CP-2623 Memory audit / make classes disposable #218

evanweible-wf opened this issue Sep 9, 2016 · 3 comments
Labels
area-src type: Improvement
Milestone
3.1.0

Comments

@evanweible-wf
Copy link
Contributor

Enable these lints:

- cancel_subscriptions
- close_sinks

Make every class disposable (add dispose() methods). Cancel subscriptions and close sinks.
@rmconsole-wf
Copy link
Contributor

It looks like you have not included any tickets in the title of this issue. Please create a ticket for this issue, or click here to have Rosie create one for you.

@evanweible-wf evanweible-wf added this to the 3.1.0 milestone Sep 9, 2016
@evanweible-wf evanweible-wf changed the title Memory audit: make classes disposable Memory audit / make classes disposable Sep 9, 2016
@rmconsole-wf rmconsole-wf changed the title Memory audit / make classes disposable CP-2623 Memory audit / make classes disposable Sep 11, 2016
@maxwellpeterson-wf
Copy link
Member

@evanweible-wf still work to be done on this one?

@evanweible-wf
Copy link
Contributor Author

Yes https://github.com/Workiva/w_transport/blob/master/analysis_options.yaml#L20-L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-src type: Improvement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@maxwellpeterson-wf @evanweible-wf @rmconsole-wf