Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local nav to Team Updates and Project Updates if possible #34

Open
ndiego opened this issue Nov 19, 2024 · 6 comments
Open

Add local nav to Team Updates and Project Updates if possible #34

ndiego opened this issue Nov 19, 2024 · 6 comments
Assignees

Comments

@ndiego
Copy link
Member

ndiego commented Nov 19, 2024

I am not sure this is possible, but it feels like the local nav should be present on the Team Updates and Project Updates pages like it is for the Meeting page. I get why they don't, though.

Meeting Project Updates Team Updates
Image Image Image

What do you think @adamwoodnz @fcoveram

@adamwoodnz
Copy link
Contributor

Yeah I tend to agree. This should be a no-code change, as the local nav for each blog is derived from the primary menu for that site. I'll wait for @fcoveram to respond first.

@adamwoodnz adamwoodnz moved this to 🛑 Pending discussion in WordPress.org Redesign Nov 19, 2024
@fcoveram
Copy link

Local nav should always be present, as per this documentation in the Design Library.

@adamwoodnz
Copy link
Contributor

Local nav should always be present, as per this documentation in the Design Library.

Ok, I'll add it.

A bit of context: what's not obvious is that these are actually separate Make blog sites (like Design, Core, Meta, etc), so having the local nav on those blogs use the home local nav is unusual, when considering them as standalone sites. Given they are not linked to from anywhere else I don't think there are any issues with this.

@adamwoodnz adamwoodnz moved this from 🛑 Pending discussion to 📋 To do in WordPress.org Redesign Nov 20, 2024
@adamwoodnz
Copy link
Contributor

I've added the local nav to those 2 blogs. There is one inconsistency left in that the site title shows the name of that blog, eg. Project Updates looks like this:

Image

Changing the title of each of these blogs to 'Make WordPress' would fix this, but I'm not sure whether that would cause confusion in other ways.

@adamwoodnz adamwoodnz moved this from 📋 To do to 🏗 In progress in WordPress.org Redesign Nov 20, 2024
@adamwoodnz adamwoodnz self-assigned this Nov 20, 2024
@fcoveram
Copy link

Thanks for the context @adamwoodnz. I see your point and understand the reason, but given that Project Updates and Team Updates have the layout and structure of make blogs, the navigation is consistent with most sections. Meeting looks more like an internal page, similar to the page listing all WordPress events, but I assume that "converting" that site into an "internal page" is out of the update scope.

Changing the title of each of these blogs to 'Make WordPress' would fix this, but I'm not sure whether that would cause confusion in other ways.

To reduce confusion chances, we could keep the site link in local nav in active state (text in bold). So when visiting the Project Updates site, the "Project Updates" link in local nav is in bold all the time. This is visually consistent with most local nav updates.

So when scrolling down, it should look like this

Image

What do you think of this?

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Nov 21, 2024

Meeting looks more like an internal page, similar to the page listing all WordPress events, but I assume that "converting" that site into an "internal page" is out of the update scope.

Meetings is actually an internal page, and I'm not sure why it's not showing an active state. I'll investigate and aim to have all the items in this local nav showing as active accordingly 👍

Rather than renaming the Team Updates and Project Updates blogs, I think I'll use a filter to change the site-title block in the local nav bar to display 'Make WordPress', so they also match the home site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants