Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for ticket 62658 #7969

Closed
wants to merge 1 commit into from

Conversation

im3dabasia
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/62658

This PR adds unit tests for the wp_get_post_autosave() function. The tests cover:

  1. Checking if a post has no autosave.
  2. Verifying that an autosave is created after a revision.
  3. Ensuring autosaves are added for a specific user.

Copy link

github-actions bot commented Dec 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props im3dabasia1, swissspidy, narenin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Author

Hey @swissspidy,

I’ve added some unit tests. This is my first time contributing to unit tests, and I included the previous diff in my PR as I wasn’t sure of the best way to write tests for the new diff.

Please, whenever you have a moment, could you check this and provide feedback?

Copy link

github-actions bot commented Dec 7, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@swissspidy
Copy link
Member

No need to create a new PR for the tests, you can add them to the existing one.

@im3dabasia
Copy link
Author

No need to create a new PR for the tests, you can add them to the existing one.

Thanks for your suggestion! I’m not entirely sure how I can push changes directly into someone else’s PR. I’m also unsure if I have write access to the branch for this PR, so I’m uncertain about the process for doing that.

When I reviewed other tickets that required unit tests in the past, I saw that a separate patch or PR was raised for those. I followed that approach here, assuming it was the preferred method.

Could you kindly guide me on how to proceed with adding the unit tests to the existing PR? I’d appreciate your help!

@narenin
Copy link

narenin commented Dec 7, 2024

@im3dabasia I have added the Test case in #7962

@mukeshpanchal27
Copy link
Member

Closing as it incorporate in original PR e961234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants