Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pagination and Bulk Action Warning Conflict #7884

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link

@im3dabasia im3dabasia commented Nov 25, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/62534

Description

This fix compares the initial and current page numbers to differentiate between a bulk action submission and a pagination action. If the page number has changed, it indicates a pagination submission, preventing the bulk action warning from triggering. This restores proper pagination functionality while ensuring the warning only appears for bulk actions when no items are selected.

Screencast Recording

Screen.Recording.2024-11-23.at.2.00.26.AM.mov

Copy link

github-actions bot commented Nov 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props im3dabasia1, joedolson, apermo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@apermo apermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beside the suggested change for the comment markup.

src/js/_enqueues/admin/common.js Outdated Show resolved Hide resolved
@im3dabasia
Copy link
Author

Looks good beside the suggested change for the comment markup.

@apermo , Fixed this as per the suggestion.

Resolve existing issue with manual entry of page 1 not working.
@joedolson
Copy link
Contributor

The problem that causes manual entry of page 1 not to work was committed in https://core.trac.wordpress.org/changeset/38752; but there's no specific documentation about why that change was made. The props were attributed to @swisspidy, however; so I'm pinging Pascal to see if he remembers anything about exactly what that fix was for.

This change appears to still preserve the desired behavior from the original ticket , while allowing the manually typed page number to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants