Tests: Fix npm tests on macOS

[ockham]

The npm tests GHA workflow has recently been failing for the macOS environment on the 6.3 branch:

Not found in manifest. Falling back to download directly from Node
[...]
Unable to find Node version '14' for platform darwin and architecture arm64.

The reason is that GHA's macos-latest test runner has recently been updated to macOS 14 "Sonoma" on Intel Silicone (arm64); OTOH, .nvmrc is pinned to node 14, which isn't available for Apple Silicone (arm64).

If we want to avoid upgrading our entire build chain from node 14 to 16 for a legacy WP branch, then our best course of action is to pin the macOS runner to an Intel-based architecture (amd64).

Per this overview, the best candidate is probably macos-13, as it's apparently the latest Intel-based macOS version runner available to public repositories.

Some prior Slack discussion here: https://wordpress.slack.com/archives/C02RQBWTW/p1714137046024979

Props @swissspidy for helping with this investigation.

Trac ticket: TBD

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[ockham]

Node 14 is now being downloaded successfully. However, the workflow is still failing:

svn: command not found

[ockham]

Node 14 is now being downloaded successfully. However, the workflow is still failing:

svn: command not found

This is the reason: https://github.blog/changelog/2024-01-08-subversion-has-been-sunset/

We'll probably need to simply remove the corresponding line, as was done e.g. in https://core.trac.wordpress.org/changeset/57249.

[swissspidy]

Makes sense to backport that change to a few older branches 👍

cc @desrosj for thoughts

[ockham]

Makes sense to backport that change to a few older branches 👍

cc @desrosj for thoughts

I pushed a commit straight to this branch. Think that's okay?

FWIW, our tests layout has changed a bit since 6.3: test-npm.yml is no more; it was absorbed into callable-test-core-build-process.yml and callable-test-gutenberg-build-process.yml.

[swissspidy]

I pushed a commit straight to this branch. Think that's okay?

For testing purposes sure, but for commit history purposes and logistical reasons I'd prefer proper backporting of said commit (including correct svn mergeinfo). Even if that means resolving some merge conflicts / manual adjustments.

Plus the change needs to be done in the 6.4 branch as well.

[desrosj]

I've been working on #6232 to make all workflows callable the last week or so. It's not quite ready, but this would be a prime example for when this alternative approach would come in handy. If all workflows are callable, we'd only have to update one branch to fix the workflow in all previous ones.

I think that both of these issues could be resolved as part of that effort instead of backporting to all past branches. I do think it's preferable to continue testing with latest in trunk and any branches that use 20.x (6.4 and newer).

If this is blocking things, I don't mind committing this to 6.3. But I would rather fix it properly for all branches at the same time.

[ockham]

I've been working on #6232 to make all workflows callable the last week or so. It's not quite ready, but this would be a prime example for when this alternative approach would come in handy. If all workflows are callable, we'd only have to update one branch to fix the workflow in all previous ones.

Makes sense, and sounds like a great improvement!

I think that both of these issues could be resolved as part of that effort instead of backporting to all past branches. I do think it's preferable to continue testing with latest in trunk and any branches that use 20.x (6.4 and newer).

If this is blocking things, I don't mind committing this to 6.3. But I would rather fix it properly for all branches at the same time.

Will this be possible for 6.3 though? After all, the problem there is that it's using Node 14 (which is unavailable on arm64, and thus in macos-latest). (Updating that branch to Node 20 seemed potentially unwieldy to me, as it'd affect our entire JS build chain.)

[ockham]

Closing as obsolete per https://core.trac.wordpress.org/changeset/58300 (ede195c).