Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

String translation in templates #30

Closed
2 tasks done
jffng opened this issue Oct 6, 2021 · 9 comments · Fixed by #182
Closed
2 tasks done

String translation in templates #30

jffng opened this issue Oct 6, 2021 · 9 comments · Fixed by #182

Comments

@jffng
Copy link
Collaborator

jffng commented Oct 6, 2021

There are currently a few strings in the block templates that we will need to figure out what to do with from a translation / i18n perspective. Let's use this issue to discuss and track what to do there:

  • Footer Credit
  • 404

Related Gutenberg issues / explorations:

@carolinan
Copy link
Collaborator

In my opinion, it is not for the theme to solve. I would leave them as is, because multi-lingual is not until phase 4.

@Soean
Copy link
Member

Soean commented Oct 18, 2021

Multilingual will solve the problem to translate and save the content of websites in different languages. Themes and Templates should be ready for localization and translation.

@carolinan
Copy link
Collaborator

And they are, because you can add your own text.

@Soean
Copy link
Member

Soean commented Oct 18, 2021

So we can't translate it globally per language, and each user has to translate it themselves and override the template, if I understand it correctly.

@aristath
Copy link
Member

So we can't translate it globally per language, and each user has to translate it themselves and override the template, if I understand it correctly.

Correct. If they want it on a different language, they can simply edit the templates. It's not like in classic themes where these were not user-editable... So IMO it's not really a blocker 👍

@kjellr
Copy link
Collaborator

kjellr commented Oct 21, 2021

While the user could go and edit those strings, they won't know that they need to. In that past, those have always been translated automatically. And for example, one of these strings is on the 404 page — it's quite likely a user won't know they need to look there and manually translate that string.

@carolinan
Copy link
Collaborator

But it is not for the theme to solve, because it is not specific to this theme.
It is a much bigger issue within Gutenberg and also with how the WordPress project will introduce block themes. It may be solved with documentation until there is a complete solution.

It is not something that can be solved before the feature freeze unless there is a decision from the 5.9 leads that it will be prioritized, and the contributors focus on it, because it has not had movement since December 2020.

@jffng
Copy link
Collaborator Author

jffng commented Oct 29, 2021

Since the pattern block was merged, this is unblocked. We should replace those strings with patterns. For the 404, it may make sense to make the pattern include all of this:

Screen Shot 2021-10-29 at 12 26 08 PM

What do you think @kjellr?

@kjellr
Copy link
Collaborator

kjellr commented Oct 29, 2021

Yeah, might as well. Let's put it at the very bottom of the "General" patterns list until we can hide it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.