Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Replacing default header with header-large-dark adds horizontal padding to it #299

Closed
zaguiini opened this issue Dec 14, 2021 · 3 comments
Closed
Labels
[Type] Bug Something isn't working

Comments

@zaguiini
Copy link
Member

zaguiini commented Dec 14, 2021

Describe the bug

When starting with a fresh site and replacing the default header template part with Header -- Dark, unexpected horizontal padding is added to the header block itself.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new site with TT2;
  2. Highlight the Header block;
  3. Click Replace on the book settings popover;
  4. Select Header -- Dark.

Verify that some horizontal padding has been added to the header itself.

Expected behavior

The header should span across the page, with no outer padding.

Screenshots

Editor Live site
image image

Additional context

This doesn't happen when:

  • adding the template part by itself;
  • adding a new header and clicking replace.

It only happens within the default Index template.

@kjellr
Copy link
Collaborator

kjellr commented Dec 14, 2021

@zaguiini I believe this should be all set as of #291. Here's a GIF of what I see when testing against the latest in this repository:

headers

@zaguiini
Copy link
Member Author

@zaguiini I believe this should be all set as of #291. Here's a GIF of what I see when testing against the latest in this repository:

headers

Awesome. Let me try again running trunk this time.

@zaguiini
Copy link
Member Author

The issue is indeed fixed. Thanks, @kjellr!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants