Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Update "Footer with navigation and copyright" and "Footer with social links and copyright" patterns to use the site title block #255

Closed
carolinan opened this issue Nov 19, 2021 · 4 comments

Comments

@carolinan
Copy link
Collaborator

Describe the bug

Could this be updated to include the site title block instead of a hard coded text? I think it would be possible now with the row block available?

<!-- wp:paragraph {"align":"center","style":{"typography":{"fontSize":"16px"}}} -->
<p class="has-text-align-center" style="font-size:16px">' . esc_html__( '© Site Title', 'twentytwentytwo' ) . '</p>
<!-- /wp:paragraph --></div>
@carolinan carolinan added [Type] Bug Something isn't working and removed [Type] Bug Something isn't working labels Nov 19, 2021
@kjellr kjellr added the [Type] Enhancement New feature or request label Nov 19, 2021
@kjellr
Copy link
Collaborator

kjellr commented Nov 19, 2021

Technically yes it can be done this way. Here's example markup:

<!-- wp:group {"layout":{"type":"flex","justifyContent":"center","flexWrap":"wrap"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"align":"center","style":{"typography":{"fontSize":"16px"}}} -->
<p class="has-text-align-center" style="font-size:16px">©</p>
<!-- /wp:paragraph -->

<!-- wp:site-title {"isLink":false,"fontSize":"small"} /--></div>
<!-- /wp:group -->

But it ends up looking wrong because the blockGap is far larger than a normal space:

Screen Shot 2021-11-19 at 10 52 08 AM

I don't think we can get that fixed without a solution to WordPress/gutenberg#35778.

@carolinan
Copy link
Collaborator Author

carolinan commented Nov 20, 2021

What about using the real site title instead of the hardcoded words, since these are PHP patterns? 🤔

@kjellr
Copy link
Collaborator

kjellr commented Nov 22, 2021

Hmm that's a good thought. My concern is that it won't stay in sync if you changed your site title though. Since the user would've already seen this intelligently populate, they'd probably think of that as a bug. 🤔

@kjellr
Copy link
Collaborator

kjellr commented Jan 24, 2022

Now that we're nearing release, I'm going to close this issue. If anyone has further thoughts to share on this topic, feel free to open up a new issue on Trac.

@kjellr kjellr closed this as completed Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants