Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Post Content padding should match in the editor and front end #234

Closed
kjellr opened this issue Nov 15, 2021 · 4 comments
Closed

Post Content padding should match in the editor and front end #234

kjellr opened this issue Nov 15, 2021 · 4 comments
Labels
Milestone

Comments

@kjellr
Copy link
Collaborator

kjellr commented Nov 15, 2021

Consolidating two existing issues into one, since they're tightly related: #144 and #5

Current issue

Currently, there's a mismatch between the way site padding behaves in the post/page editor and the frontend.

  • In the editor, post content has no padding at all, regardless of its assigned alignment (default, wide, full).
  • In the front-end, post content has appropriate default padding (since it's added to our default templates), but full-width items do not go to the screen edges.
Editor Front End
Screen Shot 2021-11-15 at 8 44 58 AM Screen Shot 2021-11-15 at 8 45 19 AM

Target appearance

Our ideal solution is:

  • Post content has a default padding that matches between the post/page editor and the front end.
  • When a top-level item in the post content is assigned to be "full-width" it should go all the way to the screen edges.

Screen Shot 2021-11-15 at 8 47 49 AM

Upstream issues/PRs:

These issues would be solved universally with a solution to the following issue:

@richtabor
Copy link
Member

Are we thinking those issues would be solved for 5.9? If not, do we have a plan B?

@kjellr
Copy link
Collaborator Author

kjellr commented Nov 18, 2021

Yes, we'll figure this out. I think we'll get to a solution in WordPress/gutenberg#35607.

A fallback would be to add CSS to handle this, but honestly I think that defeats the purpose of Gutenberg providing the layout control.

@richtabor I'm curious if you've been dealing with this issue in any other themes?

@richtabor
Copy link
Member

Yea, I’m seeing the exact issue. I’ve added a temporary negative margin hack to negate it, but its not awesome - nor is it a standardized solution that all themes would benefit from. If anything Gutenberg could work add the negative margin itself ha 🤷.

I’m hoping for a standard that every full width aligned block can be adopted into automatically without any interference from a theme.

@kjellr
Copy link
Collaborator Author

kjellr commented Dec 14, 2021

I'm going to mark this as resolved for now because #291 has merged. But we can re-open as needed.

@kjellr kjellr closed this as completed Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants