Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETL mermaid diagram is missing link text #5147

Closed
AetherUnbound opened this issue Nov 5, 2024 · 6 comments
Closed

ETL mermaid diagram is missing link text #5147

AetherUnbound opened this issue Nov 5, 2024 · 6 comments
Assignees
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: documentation Related to Sphinx documentation

Comments

@AetherUnbound
Copy link
Collaborator

Description

The ETL documentation page is missing a link: https://docs.openverse.org/meta/media_properties/etls.html

Clicking on the box does jump to the appropriate session, but we should figure out why the text isn't rendering.

Screenshots

Image

@AetherUnbound AetherUnbound added 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: documentation Related to Sphinx documentation labels Nov 5, 2024
@AetherUnbound AetherUnbound self-assigned this Nov 5, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Nov 5, 2024
@dhruvkb
Copy link
Member

dhruvkb commented Nov 7, 2024

The text is rendering correctly for me. To be extra sure, I also validated the diagram on Mermaid's Live Editor, where it also rendered correctly.

Image

@dhruvkb dhruvkb added the 🧹 status: ticket work required Needs more details before it can be worked on label Nov 7, 2024
@AetherUnbound
Copy link
Collaborator Author

Interesting!! It seems to be only rendering incorrectly for me in Firefox (including in-private browsing) 🤔 I'll have to look into this!

@AetherUnbound
Copy link
Collaborator Author

AetherUnbound commented Nov 8, 2024

Here's what I'm seeing on Firefox:
Image

The HTML looks different between that and Chrome too.
Chrome

<g id="flowchart-ESF-15" class="node default ETL clickable">
    <rect height="78" width="230" y="-39" x="-115" ry="5" data-et="node" data-id="abc" rx="5" style="fill:#fa7def !important" class="basic label-container"></rect>
    <g transform="translate(-100, -24)" style="" class="label">
        <rect></rect>
        <foreignObject height="48" width="200">
            <div style="display: table; white-space: break-spaces; line-height: 1.5; max-width: 200px; text-align: center; width: 200px;" xmlns="http://www.w3.org/1999/xhtml">
            <span class="nodeLabel"><p>Index creation &amp; deleted media filtering</p></span></div>
        </foreignObject>
    </g>
</g>

Firefox

<g id="flowchart-ESF-15" class="node default ETL clickable">
    <rect height="30" width="30" y="-15" x="-15" ry="5" data-et="node" data-id="abc" rx="5" style="fill:#fa7def !important" class="basic label-container"></rect>
    <g transform="translate(0, 0)" style="" class="label">
        <rect></rect>
        <foreignObject height="0" width="0">
            <div xmlns="http://www.w3.org/1999/xhtml" style="display: table; white-space: break-spaces; line-height: 1.5; max-width: 200px; text-align: center; width: 200px;">
            <span class="nodeLabel"><p>Index creation &amp; deleted media filtering</p></span></div>
        </foreignObject>
    </g>
</g>

@dhruvkb
Copy link
Member

dhruvkb commented Nov 8, 2024

I am also able to reproduce the bug on Firefox so it is indeed a problem, but it only happens on the docs site. The same diagram, copied into Mermaid's live editor, renders correctly on Firefox.

@dhruvkb dhruvkb removed the 🧹 status: ticket work required Needs more details before it can be worked on label Nov 8, 2024
@AetherUnbound
Copy link
Collaborator Author

I wonder if it's part of our CSS or perhaps the way Sphinx is rendering things?

@AetherUnbound
Copy link
Collaborator Author

Unfortunately I think this either has to do with the Mermaid extension for Sphinx or some other aspect upstream 😞 - I'll close this for now.

@AetherUnbound AetherUnbound closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 🗑 Discarded in Openverse Backlog Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: documentation Related to Sphinx documentation
Projects
Status: 🗑 Discarded
Development

No branches or pull requests

2 participants