Skip to content

Commit

Permalink
Add syntax and check declarations in Dockerfiles (#5183)
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvkb authored Nov 25, 2024
1 parent 5531359 commit 507a1ea
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

# Automatically build image using Python version specified in `pyproject.toml`
ARG API_PY_VERSION
Expand Down
1 change: 1 addition & 0 deletions catalog/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

# Cannot use $PYTHON_VERSION because that is overwritten by the base image
# with the patch version (we only care about major and minor version)
Expand Down
2 changes: 2 additions & 0 deletions docker/dev_env/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# syntax=docker/dockerfile:1

FROM docker.io/library/fedora:40

# We want to keep all important things in `/opt` as we will preserve the
Expand Down
1 change: 1 addition & 0 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

# Automatically build image using Node.js version specified in `package.json`.
ARG FRONTEND_NODE_VERSION
Expand Down
1 change: 1 addition & 0 deletions frontend/Dockerfile.playwright
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

ARG PLAYWRIGHT_VERSION

Expand Down
1 change: 1 addition & 0 deletions indexer_worker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

# Automatically build image using Python version specified in the `Pipfile`.
ARG INDEXER_WORKER_PY_VERSION
Expand Down
1 change: 1 addition & 0 deletions ingestion_server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# syntax=docker/dockerfile:1
# check=skip=InvalidDefaultArgInFrom

# Automatically build image using Python version specified in the `Pipfile`.
ARG INGESTION_PY_VERSION
Expand Down

0 comments on commit 507a1ea

Please sign in to comment.