Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post title: Re-add the paragraph level (without UI) #60548

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Post title: Re-add the paragraph level (without UI) #60548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baed8af
Post title: Re-add the paragraph level
carolinan Apr 8, 2024
197a7dc
Remove the paragraph from the level dropdown
carolinan Apr 8, 2024
be98ddb
Merge branch 'trunk' into update/post-title-paragraph
carolinan Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/block-library/src/post-title/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ import { createBlock, getDefaultBlockName } from '@wordpress/blocks';
import { useEntityProp, store as coreStore } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';

const HEADING_LEVELS = [ 0, 1, 2, 3, 4, 5, 6 ];

export default function PostTitleEdit( {
attributes: { level, textAlign, isLink, rel, linkTarget },
setAttributes,
context: { postType, postId, queryId },
insertBlocksAfter,
} ) {
const TagName = 'h' + level;
const TagName = level === 0 ? 'p' : `h${ level }`;
const isDescendentOfQueryLoop = Number.isFinite( queryId );
const userCanEdit = useSelect(
( select ) => {
Expand Down Expand Up @@ -124,6 +126,7 @@ export default function PostTitleEdit( {
<>
<BlockControls group="block">
<HeadingLevelDropdown
options={ HEADING_LEVELS }
value={ level }
onChange={ ( newLevel ) =>
setAttributes( { level: newLevel } )
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-title/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function render_block_core_post_title( $attributes, $content, $block ) {

$tag_name = 'h2';
if ( isset( $attributes['level'] ) ) {
$tag_name = 'h' . $attributes['level'];
$tag_name = 0 === $attributes['level'] ? 'p' : 'h' . (int) $attributes['level'];
}

if ( isset( $attributes['isLink'] ) && $attributes['isLink'] ) {
Expand Down
Loading