Site Editor: Fix routing for Classic themes using block-based template parts #48343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Regression
kevin940726
reviewed
Feb 23, 2023
| ); | ||
|
|
||
| const templatePart = page | ||
| .getByRole( 'table' ) |
There was a problem hiding this comment.
Off-topic: We should probably fix this by giving the table an accessible name in another PR 😅 .
|
Size Change: +26 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Feb 23, 2023
| */ | ||
| const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
|
||
| test.describe( 'Template Parts for Classic themes', () => { |
There was a problem hiding this comment.
Great idea to have an e2e test for this, we don't check this flow often manually.
youknowriad
reviewed
Feb 23, 2023
| return ( | ||
| <SidebarNavigationScreen | ||
| isRoot={ isTemplatePartsMode } |
There was a problem hiding this comment.
This is a bit weird to be honest, I think the ideal solution for this "mode" is to probably have its own "init function" rather than rely on the default site editor initialization function. In the long term, I'm certain this "hack" is going to bite us. By "Hack" I mean the fact that we kind of try to load a specific version of the site editor for the "template parts" screen of classic themes.
There was a problem hiding this comment.
It's still the same site editor; we don't want some routes to be available for Classic themes.
But I agree this "hack" isn't the best way to solve this problem. I will try to explore different init methods for WP 6.3.
youknowriad
approved these changes
Feb 23, 2023
|
Flaky tests detected in 15e9490. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4250314345
|
fabiankaegy
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
I tested this locally on a site that has been using this feature since it was originally released. I can confirm this works on WordPress 6.2 Beta 3 with this version of Gutenberg activated.
Thank you for the fix :)
Something that is a little confusing though is the navigation sidebar. You correctly get moved to the "Manage all template parts screen" but that means that you now have to navigate back by two levels. And the one in between is kind of odd because it shows the same exact information that you already see. (see attached video)
CleanShot.2023-02-23.at.10.28.06.mp4
|
Thanks for testing, @fabiankaegy! I tried to make as few changes to the new sidebar navigation as possible. Viewing the list in the sidebar might be confusing, but I found it helpful when navigating away editor. Let's explore a better editor initialization for the next major release - #48343 (comment). |
ntsekouras
added
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
…e parts (#48343) * Site Editor: Fix routing for Classic themes using block-based template parts * Add basic e2e tests * Update theme stylesheet name
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 21ba2d8 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 28, 2023
To display a list of block-based template parts for classic themes, this changeset adds a `path` query arg to the Appearance > Template Parts menu URL. This change is necessary due to recent changes to Site Editor's client-side routing. Reference: * [WordPress/gutenberg#48343 Gutenberg PR 48343] * [WordPress/gutenberg#42729 Gutenberg PR 42729] Follow-up to [55392], [54176]. Props mamaduka, audrasjb, fabiankaegy, hellofromTonya, kevin940726, mukesh27, youknowriad. Fixes #57819. git-svn-id: https://develop.svn.wordpress.org/trunk@55435 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 28, 2023
To display a list of block-based template parts for classic themes, this changeset adds a `path` query arg to the Appearance > Template Parts menu URL. This change is necessary due to recent changes to Site Editor's client-side routing. Reference: * [WordPress/gutenberg#48343 Gutenberg PR 48343] * [WordPress/gutenberg#42729 Gutenberg PR 42729] Follow-up to [55392], [54176]. Props mamaduka, audrasjb, fabiankaegy, hellofromTonya, kevin940726, mukesh27, youknowriad. Fixes #57819. Built from https://develop.svn.wordpress.org/trunk@55435 git-svn-id: http://core.svn.wordpress.org/trunk@54968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Feb 28, 2023
To display a list of block-based template parts for classic themes, this changeset adds a `path` query arg to the Appearance > Template Parts menu URL. This change is necessary due to recent changes to Site Editor's client-side routing. Reference: * [WordPress/gutenberg#48343 Gutenberg PR 48343] * [WordPress/gutenberg#42729 Gutenberg PR 42729] Follow-up to [55392], [54176]. Props mamaduka, audrasjb, fabiankaegy, hellofromTonya, kevin940726, mukesh27, youknowriad. Fixes #57819. Built from https://develop.svn.wordpress.org/trunk@55435 git-svn-id: https://core.svn.wordpress.org/trunk@54968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
To display a list of block-based template parts for classic themes, this changeset adds a `path` query arg to the Appearance > Template Parts menu URL. This change is necessary due to recent changes to Site Editor's client-side routing. Reference: * [WordPress/gutenberg#48343 Gutenberg PR 48343] * [WordPress/gutenberg#42729 Gutenberg PR 42729] Follow-up to [55392], [54176]. Props mamaduka, audrasjb, fabiankaegy, hellofromTonya, kevin940726, mukesh27, youknowriad. Fixes #57819. Built from https://develop.svn.wordpress.org/trunk@55435 git-svn-id: http://core.svn.wordpress.org/trunk@54968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the new site editor navigation screen and routing to work with "Template Parts Mode".
I've also included new E2E tests to catch similar regressions as early as possible.
See #42729 for more details about the original feature.
Why?
There were a few regressions after recent Site Editor refactoring.
How?
SidebarNavigationScreenTemplatesis set to be the root when an editor is accessed in this mode.Testing Instructions
The templates sidebar navigation screen works as before for block themes.
emptyhybridtheme. It can be symlinked from the plugin.Screenshots or screencast
CleanShot.2023-02-23.at.11.12.49.mp4