From bc601850d838e8810304f932d7886ac4226c21c9 Mon Sep 17 00:00:00 2001 From: brookewp Date: Wed, 14 Dec 2022 14:29:35 -0800 Subject: [PATCH 1/4] TextareaControl: add new opt-in prop --- packages/block-library/src/cover/edit/inspector-controls.js | 1 + packages/block-library/src/image/image.js | 1 + packages/block-library/src/media-text/edit.js | 1 + packages/block-library/src/navigation-link/edit.js | 1 + packages/block-library/src/navigation-submenu/edit.js | 1 + packages/edit-site/src/components/global-styles/custom-css.js | 1 + packages/editor/src/components/post-excerpt/index.js | 1 + 7 files changed, 7 insertions(+) diff --git a/packages/block-library/src/cover/edit/inspector-controls.js b/packages/block-library/src/cover/edit/inspector-controls.js index d3f65672e09328..6160f5d7828d6a 100644 --- a/packages/block-library/src/cover/edit/inspector-controls.js +++ b/packages/block-library/src/cover/edit/inspector-controls.js @@ -180,6 +180,7 @@ export default function CoverInspectorControls( { isImageBackground && isImgElement && ( { ! multiImageSelection && ( { setAttributes( { description: descriptionValue } ); diff --git a/packages/block-library/src/navigation-submenu/edit.js b/packages/block-library/src/navigation-submenu/edit.js index 47a222bd57bb66..a6029e98661ddc 100644 --- a/packages/block-library/src/navigation-submenu/edit.js +++ b/packages/block-library/src/navigation-submenu/edit.js @@ -481,6 +481,7 @@ export default function NavigationSubmenuEdit( { autoComplete="off" /> { setAttributes( { diff --git a/packages/edit-site/src/components/global-styles/custom-css.js b/packages/edit-site/src/components/global-styles/custom-css.js index 6c7d3de1cf06e5..61aad940cd372f 100644 --- a/packages/edit-site/src/components/global-styles/custom-css.js +++ b/packages/edit-site/src/components/global-styles/custom-css.js @@ -42,6 +42,7 @@ function CustomCSSControl() { return ( <> onUpdateExcerpt( value ) } From c4e0c74bc67b734f21745099f772127a66096a85 Mon Sep 17 00:00:00 2001 From: brookewp Date: Wed, 14 Dec 2022 14:38:07 -0800 Subject: [PATCH 2/4] Remove margin bottom and replace div with VStack for Disabled component --- packages/components/src/disabled/stories/index.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/components/src/disabled/stories/index.tsx b/packages/components/src/disabled/stories/index.tsx index 06246adde633f1..81f2bf4c079233 100644 --- a/packages/components/src/disabled/stories/index.tsx +++ b/packages/components/src/disabled/stories/index.tsx @@ -15,6 +15,7 @@ import Disabled from '../'; import SelectControl from '../../select-control/'; import TextControl from '../../text-control/'; import TextareaControl from '../../textarea-control/'; +import { VStack } from '../../v-stack/'; const meta: ComponentMeta< typeof Disabled > = { title: 'Components/Disabled', @@ -37,18 +38,21 @@ const Form = () => { const [ textControlValue, setTextControlValue ] = useState( '' ); const [ textAreaValue, setTextAreaValue ] = useState( '' ); return ( -
+ {} } options={ [ @@ -58,7 +62,7 @@ const Form = () => { { value: 'c', label: 'Option C' }, ] } /> -
+ ); }; From 4be7fc39e6ad7fd613926d4f9abd53dd19c67095 Mon Sep 17 00:00:00 2001 From: brookewp Date: Wed, 14 Dec 2022 17:41:45 -0800 Subject: [PATCH 3/4] Update Changelog --- packages/components/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index f459061f109e19..90f21dd9cbc1a0 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -31,6 +31,7 @@ - Lighten the border color on control components ([#46252](https://github.com/WordPress/gutenberg/pull/46252)). - `Popover`: Prevent unnecessary paint when scrolling by using transform instead of top/left positionning ([#46187](https://github.com/WordPress/gutenberg/pull/46187)). - `CircularOptionPicker`: Prevent unecessary paint on hover ([#46197](https://github.com/WordPress/gutenberg/pull/46197)). +- `Disabled`: Replace bottom margin overrides with `__nextHasNoMarginBottom` ([#46559](https://github.com/WordPress/gutenberg/pull/46559)). ### Experimental @@ -62,6 +63,7 @@ - `TabPanel`: Add ability to set icon only tab buttons ([#45005](https://github.com/WordPress/gutenberg/pull/45005)). ### Internal + - `AnglePickerControl`: remove `:focus-visible' outline on `CircleOutlineWrapper` ([#45758](https://github.com/WordPress/gutenberg/pull/45758)) ### Bug Fix From 709e31f14e7389e35cf1ba6c482a0857bc12374b Mon Sep 17 00:00:00 2001 From: brookewp Date: Fri, 16 Dec 2022 10:11:29 -0800 Subject: [PATCH 4/4] Revert "Update Changelog" This reverts commit 95562a919a9e8c84b40e394c471a738a12b01c50. --- packages/components/CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 90f21dd9cbc1a0..f459061f109e19 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -31,7 +31,6 @@ - Lighten the border color on control components ([#46252](https://github.com/WordPress/gutenberg/pull/46252)). - `Popover`: Prevent unnecessary paint when scrolling by using transform instead of top/left positionning ([#46187](https://github.com/WordPress/gutenberg/pull/46187)). - `CircularOptionPicker`: Prevent unecessary paint on hover ([#46197](https://github.com/WordPress/gutenberg/pull/46197)). -- `Disabled`: Replace bottom margin overrides with `__nextHasNoMarginBottom` ([#46559](https://github.com/WordPress/gutenberg/pull/46559)). ### Experimental @@ -63,7 +62,6 @@ - `TabPanel`: Add ability to set icon only tab buttons ([#45005](https://github.com/WordPress/gutenberg/pull/45005)). ### Internal - - `AnglePickerControl`: remove `:focus-visible' outline on `CircleOutlineWrapper` ([#45758](https://github.com/WordPress/gutenberg/pull/45758)) ### Bug Fix