Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block: Update placeholder minHeight style to support non-px units #35614

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Cover block: Update placeholder minHeight style to support non-px units #35614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/block-library/src/cover/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function CoverHeightInput( {
const handleOnChange = ( unprocessedValue ) => {
const inputValue =
unprocessedValue !== ''
? parseInt( unprocessedValue, 10 )
? parseFloat( unprocessedValue )
: undefined;

if ( isNaN( inputValue ) && inputValue !== undefined ) {
Expand Down Expand Up @@ -148,7 +148,6 @@ function CoverHeightInput( {
onBlur={ handleOnBlur }
onChange={ handleOnChange }
onUnitChange={ onUnitChange }
step="1"
style={ { maxWidth: 80 } }
unit={ unit }
units={ units }
Expand Down Expand Up @@ -637,7 +636,12 @@ function CoverEdit( {
noticeUI={ noticeUI }
onSelectMedia={ onSelectMedia }
noticeOperations={ noticeOperations }
style={ { minHeight: temporaryMinHeight || minHeight } }
style={ {
minHeight:
temporaryMinHeight ||
minHeightWithUnit ||
undefined,
} }
>
<div className="wp-block-cover__placeholder-background-options">
<ColorPalette
Expand Down