Cover block: Update placeholder minHeight style to support non-px units #35614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
CC: @ramonjd and @jasmussen 🙂 |
|
Size Change: -14 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
✅ Non-px units like em and rem should work correctly in the Cover block's placeholder state.
✅ Also check that the addition of decimal / floating point values doesn't cause any issues.
✅ Check that dragging the ResizableCover control still switches the unit to px as expected.
Thanks a lot for nabbing this one @andrewserong
Checked in Block and Site Editors. 👍
Values saved as expected on frontend. 👍
LGTM 🚢
andrewserong
deleted the
update/cover-block-placeholder-min-height-to-support-non-px-units
branch
|
⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from #35068, this small PR ensures that the placeholder minimum height styles supports non-px units. Currently, the minimum height value is treated as a
pxvalue when applied to the placeholder's height, irrespective of the unit selected.At the same time, for consistency with non-px units, the update logic is changed to use
parseFloatinstead ofparseInt(to support decimal values in units likeem,rem,vw,vh), and the hard-codedstep="1"is removed to also support the fractional default step values for non-px units.How has this been tested?
In the editor, add a Cover block. In its placeholder state, go to update the minimum height of the cover, and switch to a non-px unit like
em. As you increase the number, note that before this PR, the value in the editor is treated aspx. The real non-px value is still being correctly saved to the post content.With this PR applied, note that non-px units like
emandremshould work correctly in the Cover block's placeholder state. Also check that the addition of decimal / floating point values doesn't cause any issues.Check that dragging the ResizableCover control still switches the unit to
pxas expected.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).